Why the menu closing animation has unhandled promise reject?

[VietNguyenQuoc]

I don't know if it's a bug or some intended implementation.
I'm wrapping the menu with React and sometimes it crashes when closing the menu with animation (quick=true works)

Diving into the material code, I see that it will reject a promise in several scenarios:

• no anchor or surface elements
• there's another closing animation fired after the current one.

Can someone explain why the menu closing animation has to reject the promise in here and why the promise rejection is not handled in here?

[VietNguyenQuoc]

@asyncLiz @e111077 can you help with this?

[asyncLiz]

At a glance I don't think I see a reason for animateClose() on the menu to reject the promise. I think it can just resolve early instead of rejecting when there aren't elements or when animations are canceled.

@e111077 do you agree? If so that should be a simple PR we can accept.

[e111077]

probably should resolve early. Wanted to make sure there was some way to determine the difference between whether it succeeded or failed (can probably just do resolve(false)), but likely YAGNI.

[asyncLiz]

Thanks Elliott! @VietNguyenQuoc could you send a PR that changes the rejections to resolve instead?

[VietNguyenQuoc]

thanks @asyncLiz @e111077, I'll send the PR.

[VietNguyenQuoc]

Oh I see @e111077 already done that.