fix(dialog)!: remove toggleShow()

BREAKING CHANGE: Use dialog.open, dialog.show(), and dialog.close() instead. PiperOrigin-RevId: 553622255
material-components · Aug 3, 2023 · b992b15 · b992b15
1 parent 500472b
commit b992b15
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 23 deletions.
diff --git a/dialog/dialog_test.ts b/dialog/dialog_test.ts
@@ -77,18 +77,13 @@ describe('<md-dialog>', () => {
       expect(await harness.isDialogVisible()).toBeFalse();
     });
 
-    it('renders open state by calling show()/close()/toggleShow()',
-       async () => {
-         const {harness} = await setupTest();
-         harness.element.show();
-         expect(await harness.isDialogVisible()).toBeTrue();
-         harness.element.close();
-         expect(await harness.isDialogVisible()).toBeFalse();
-         harness.element.toggleShow();
-         expect(await harness.isDialogVisible()).toBeTrue();
-         harness.element.toggleShow();
-         expect(await harness.isDialogVisible()).toBeFalse();
-       });
+    it('renders open state by calling show()/close()', async () => {
+      const {harness} = await setupTest();
+      harness.element.show();
+      expect(await harness.isDialogVisible()).toBeTrue();
+      harness.element.close();
+      expect(await harness.isDialogVisible()).toBeFalse();
+    });
 
     it('renders scrim', async () => {
       const {harness} = await setupTest();

diff --git a/dialog/internal/dialog.ts b/dialog/internal/dialog.ts
@@ -159,17 +159,6 @@ export class Dialog extends LitElement {
     this.open = false;
   }
 
-  /**
-   * Opens and shows the dialog if it is closed; otherwise closes it.
-   */
-  toggleShow() {
-    if (this.open) {
-      this.close(this.currentAction);
-    } else {
-      this.show();
-    }
-  }
-
   private getContentScrollInfo() {
     if (!this.hasUpdated || !this.contentElement) {
       return {isScrollable: false, isAtScrollTop: true, isAtScrollBottom: true};