chore(package): update testdouble to version 3.2.0 #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lynnmercier
commented
Jun 26, 2017
lynnmercier
commented
- changed mdc-animation tests to no longer mock 'createElement'
- changed mdc-base tests to no longer mock 'rootElementAtTimeOfCall'
* changed mdc-animation tests to no longer mock 'createElement' * changed mdc-base tests to no longer mock 'rootElementAtTimeOfCall'
yeelan0319
suggested changes
Jun 27, 2017
There was a problem hiding this comment.
We already have a PR out for bumping the testdouble version #857 . The reason we pin it down to 3.0.0 is because TravisCI bugs out last time when we had the latest version. So we should check why the test failed and merge that one instead.
Codecov Report
@@ Coverage Diff @@
## master #865 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 71 71
Lines 3266 3266
Branches 393 393
=======================================
Hits 3211 3211
Misses 55 55Continue to review full report at Codecov.
|
yeelan0319
approved these changes
Jul 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.