feat(segmented-button): Add ripple and touch-target support #6277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseamon
reviewed
Jul 27, 2020
gschrag
commented
Jul 27, 2020
gschrag
commented
Jul 27, 2020
|
I've noticed an issue where the background color of a selected segment causes the border color to be darker (because it's mostly transparent). Does anyone know how to keep the colors from overlapping? |
abhiomkar
requested changes
Jul 30, 2020
|
Let me know when this PR is ready for re-review. Thanks! |
add ripple effects and support touch wrapper div
…vior remove references to feature-targeting-mixins/-functions and remove ability to change outline-color based on selection status
remove unnecessary units
better modularity and remove deprecated usage
update to new segment/styles file
remove deprecated dependency on feature-targeting's mixin
abhiomkar
approved these changes
Aug 6, 2020
abhiomkar
reviewed
Aug 6, 2020
rearrange placement of styles and mixins, remove custom-properties.apply(), and remove ripple common mixin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ripple effects and support touch-target wrapper div