feat(form-field): Add support for space-between #5759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_303416506
branch
from
36b2cce
to
7441c47
Compare
This PR adds `mdc-form-field--space-between` class. fixes: #5747 This allows easily creating this layout:  https://jsfiddle.net/Misiu/quzgcsev/25/ Sample code: ``` <div class="mdc-form-field mdc-form-field--space-between" id="form1"> <div class="mdc-switch" id="switch1"> <div class="mdc-switch__track"></div> <div class="mdc-switch__thumb-underlay"> <div class="mdc-switch__thumb"></div> <input type="checkbox" id="basic-switch1" class="mdc-switch__native-control" role="switch" aria-checked="false"> </div> </div> <label for="basic-switch1">off/on</label> </div> ``` I've added support for `mdc-form-field--align-end`, but I'm not sure how support for RTL languages should look. Also, this is my first PR in this repo, so sorry for any mistakes. PiperOrigin-RevId: 304204642
copybara-service
bot
force-pushed
the
test_303416506
branch
from
7441c47
to
e84b9c8
Compare
|
See #5754 for the full history of this PR. Copybara created a duplicate PR and merged the wrong one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(form-field): Add support for space-between
This PR adds
mdc-form-field--space-betweenclass.fixes: #5747
This allows easily creating this layout:
https://jsfiddle.net/Misiu/quzgcsev/25/
Sample code:
I've added support for
mdc-form-field--align-end, but I'm not sure how support for RTL languages should look.Also, this is my first PR in this repo, so sorry for any mistakes.