fix(floatinglabel): Estimate hidden scroll width #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyncLiz
reviewed
Jan 10, 2020
|
All 545 screenshot tests passed for commit 32f410d vs. |
|
All 545 screenshot tests passed for commit f400795 vs. |
|
All 545 screenshot tests passed for commit e933b88 vs. |
asyncLiz
reviewed
Jan 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #5448 +/- ##
==========================================
+ Coverage 97.33% 97.33% +<.01%
==========================================
Files 164 164
Lines 6257 6269 +12
Branches 825 826 +1
==========================================
+ Hits 6090 6102 +12
Misses 167 167
Continue to review full report at Codecov.
|
|
All 545 screenshot tests passed for commit 8372503 vs. |
|
All 545 screenshot tests passed for commit f9a5ab9 vs. |
|
All 545 screenshot tests passed for commit 5936803 vs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the floating label needs to immediately know its width. This creates problems if the floating label is instantiated inside a
display: none;parent element, like a hidden dialog. To resolve that, we provide a helper method that estimates the width of an element if hidden. If visible, it computes the true width.