Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(switch): set track border to be transparent #5323

Merged
merged 3 commits into from
Dec 12, 2019
Merged

fix(switch): set track border to be transparent #5323

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2c9b58
fix(switch): Set track border to be transparent
allan-chen Dec 11, 2019
bc443be
update screenshots
allan-chen Dec 12, 2019
a4058ca
Merge branch 'master' into cl_284822775
allan-chen Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/mdc-switch/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@
&.mdc-switch--checked .mdc-switch__track {
@include mdc-feature-targets($feat-color) {
@include mdc-theme-prop(background-color, $color);
@include mdc-theme-prop(border-color, $color);
}
}
}
Expand Down Expand Up @@ -174,7 +173,6 @@
&:not(.mdc-switch--checked) .mdc-switch__track {
@include mdc-feature-targets($feat-color) {
@include mdc-theme-prop(background-color, $color);
@include mdc-theme-prop(border-color, $color);
}
}
}
Expand Down Expand Up @@ -272,6 +270,7 @@
@mixin mdc-switch__track_($query: mdc-feature-all()) {
$feat-animation: mdc-feature-create-target($query, animation);
$feat-structure: mdc-feature-create-target($query, structure);
$feat-color: mdc-feature-create-target($query, color);

@include mdc-feature-targets($feat-structure) {
box-sizing: border-box;
Expand All @@ -288,6 +287,10 @@
mdc-switch-transition(background-color),
mdc-switch-transition(border-color);
}

@include mdc-feature-targets($feat-color) {
@include mdc-theme-prop(border-color, transparent);
}
}

@mixin mdc-switch__thumb-underlay_($query: mdc-feature-all()) {
Expand Down