Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(checkbox): Add Jasmine test for checkbox foundation. #5299

Merged
merged 18 commits into from
Dec 9, 2019

Conversation

joyzhong
Copy link
Contributor

@joyzhong joyzhong commented Dec 3, 2019

  • Add checkbox foundation test using Jasmine framework (converted from existing Mocha test). Does not delete Mocha test yet; this will be done in a follow-up PR.
  • Set up Karma config such that npm run test:jasmineunit runs Karma/Jasmine unit tests, npm run test:mochaunit runs Karma/Mocha unit tests, and npm run test:unit runs both.
  • Set up code coverage via karma-typescript/istanbul. Thresholds are lowered for now since Jasmine tests do not cover component tests, which were increasing the coverage percentage.

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #5299 into master will decrease coverage by 0.32%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5299      +/-   ##
=========================================
- Coverage   98.63%   98.3%   -0.33%     
=========================================
  Files         122     162      +40     
  Lines        6000    6311     +311     
  Branches      772     866      +94     
=========================================
+ Hits         5918    6204     +286     
- Misses         81     106      +25     
  Partials        1       1
Impacted Files Coverage Δ
testing/helpers/setup.ts 100% <100%> (ø)
testing/helpers/foundation.ts 87.23% <87.23%> (ø)
packages/mdc-dom/events.ts 90.9% <0%> (-9.1%) ⬇️
packages/mdc-ripple/util.ts 82.35% <0%> (-7.65%) ⬇️
packages/mdc-auto-init/index.ts 92% <0%> (-3.84%) ⬇️
packages/mdc-base/component.ts 93.33% <0%> (-3.1%) ⬇️
packages/mdc-top-app-bar/component.ts 98.5% <0%> (-1.5%) ⬇️
packages/mdc-drawer/component.ts 98.7% <0%> (-1.3%) ⬇️
packages/mdc-chips/chip-set/component.ts 97.4% <0%> (-1.29%) ⬇️
packages/mdc-tab-bar/foundation.ts 98.89% <0%> (-1.11%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7b71a...ef328ba. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 89fd463 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit e8fe73d vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 37977e3 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit f1accc0 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 4997bd0 vs. master! 💯🎉

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

karma.conf.js Show resolved Hide resolved
packages/mdc-checkbox/.npmignore Show resolved Hide resolved
testing/helpers/foundation.ts Outdated Show resolved Hide resolved
packages/mdc-checkbox/test/foundation.test.ts Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 18e505a vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 43b81f4 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit e67d884 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 032a1ba vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit feb7d1d vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 6c08dca vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 6929207 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 406d532 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 7d2631d vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit ef328ba vs. master! 💯🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants