Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chips): Consolidate interaction event handlers #5251

Merged
merged 3 commits into from
Nov 20, 2019

Conversation

patrickrodee
Copy link
Contributor

@patrickrodee patrickrodee commented Nov 13, 2019

Consolidate interaction event handlers into discrete root-level handlers: handleClick and handleKeydown.

BREAKING CHANGE: the handleInteraction and handleTrailingIconInteraction handlers have been removed from the MDCChipFoundation. The handleClick handler has been added to the MDCChipFoundation

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 3f7af7f vs. master! 💯🎉

@patrickrodee patrickrodee changed the title feat(chips): Combine event handlers feat(chips): Consolidate interaction event handlers Nov 18, 2019
@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3cbee6d). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5251   +/-   ##
=========================================
  Coverage          ?   98.63%           
=========================================
  Files             ?      122           
  Lines             ?     6002           
  Branches          ?      772           
=========================================
  Hits              ?     5920           
  Misses            ?       81           
  Partials          ?        1
Impacted Files Coverage Δ
packages/mdc-chips/chip/component.ts 98.96% <100%> (ø)
packages/mdc-chips/chip/foundation.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cbee6d...d7225b7. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit d7225b7 vs. master! 💯🎉

@patrickrodee patrickrodee requested review from abhiomkar, mmalerba and joyzhong and removed request for abhiomkar November 18, 2019 20:24
@joyzhong joyzhong self-assigned this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants