Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elevation): Add elevation overlay mixins #5249

Merged
merged 10 commits into from
Nov 14, 2019
Merged

feat(elevation): Add elevation overlay mixins #5249

merged 10 commits into from
Nov 14, 2019

Conversation

patrickrodee
Copy link
Contributor

@patrickrodee patrickrodee commented Nov 12, 2019 •
edited
Loading

Add mixins to set the overlay fill color, opacity, size, parent position, and shadow.

BREAKING CHANGE: Functions moved into the _functions.scss file

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 3a42b10 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 94d9a6c vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 2f05320 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit ad8bcd4 vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Nov 13, 2019 •
edited
Loading

Codecov Report

Merging #5249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5249   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files         122      122           
  Lines        6002     6002           
  Branches      774      774           
=======================================
  Hits         5920     5920           
  Misses         81       81           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7161170...25f2136. Read the comment docs.

joyzhong
joyzhong suggested changes Nov 13, 2019
View reviewed changes
packages/mdc-elevation/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-elevation/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-elevation/_mixins.scss Outdated Show resolved Hide resolved
abhiomkar
abhiomkar requested changes Nov 13, 2019
View reviewed changes
Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Left few comments.

packages/mdc-elevation/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-elevation/_variables.scss Show resolved Hide resolved
packages/mdc-elevation/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-elevation/_mixins.scss Show resolved Hide resolved
packages/mdc-elevation/README.md Show resolved Hide resolved
packages/mdc-elevation/_mixins.scss Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 0bf8fc6 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit eed653e vs. master! 💯🎉

abhiomkar
abhiomkar requested changes Nov 14, 2019
View reviewed changes
packages/mdc-elevation/README.md Outdated Show resolved Hide resolved
packages/mdc-elevation/_mixins.scss Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 25f2136 vs. master! 💯🎉

abhiomkar
abhiomkar approved these changes Nov 14, 2019
View reviewed changes
Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding clear docs!

@patrickrodee patrickrodee merged commit b4cfdc4 into master Nov 14, 2019
@patrickrodee patrickrodee deleted the feat/elevationoverlay01 branch November 14, 2019 15:54
@github-actions github-actions bot mentioned this pull request Feb 13, 2020
Merged
@github-actions github-actions bot mentioned this pull request Feb 13, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@adrianschmidt adrianschmidt mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiomkar abhiomkar abhiomkar approved these changes

@joyzhong joyzhong joyzhong approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@patrickrodee @mdc-web-bot @codecov-io @abhiomkar @joyzhong @googlebot