Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linear-progress): Add aria attributes to linear progress bar to support screen readers #5248

Merged

Conversation

rbuckheit
Copy link
Contributor

@rbuckheit rbuckheit commented Nov 11, 2019

fix(linear-progress) support aria attributes

Adds aria attributes to MDC Linear progress to support screen readers.

BREAKING CHANGE: Adds new adapter methods to MDCLinearProgressAdapter.

@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #5248 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5248      +/-   ##
==========================================
+ Coverage   98.63%   98.91%   +0.28%     
==========================================
  Files         122      122              
  Lines        6002     6011       +9     
  Branches      774      774              
==========================================
+ Hits         5920     5946      +26     
+ Misses         81       64      -17     
  Partials        1        1
Impacted Files Coverage Δ
packages/mdc-linear-progress/foundation.ts 100% <100%> (ø) ⬆️
packages/mdc-linear-progress/component.ts 96.96% <100%> (+0.41%) ⬆️
packages/mdc-checkbox/component.ts 96.87% <0%> (+1.04%) ⬆️
packages/mdc-tab/component.ts 98.36% <0%> (+3.27%) ⬆️
packages/mdc-base/component.ts 100% <0%> (+3.57%) ⬆️
packages/mdc-ripple/component.ts 100% <0%> (+3.77%) ⬆️
packages/mdc-auto-init/index.ts 100% <0%> (+4.16%) ⬆️
packages/mdc-ripple/util.ts 97.56% <0%> (+4.87%) ⬆️
packages/mdc-switch/component.ts 98.27% <0%> (+6.89%) ⬆️
packages/mdc-radio/component.ts 95.83% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4b4e2...675c9c7. Read the comment docs.

@rbuckheit rbuckheit changed the title fix(linearprogress-aria) fix(linearprogress-aria): Adds aria attributes to MDC Linear progress to support screen readers Nov 11, 2019
@rbuckheit rbuckheit changed the title fix(linearprogress-aria): Adds aria attributes to MDC Linear progress to support screen readers fix(linearprogress-aria): Add aria attributes to linear progress bar to support screen readers Nov 11, 2019
Copy link
Contributor

@joyzhong joyzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please add a BREAKING CHANGE message to the description per https://github.com/angular/angular/blob/master/CONTRIBUTING.md#footer, since we're adding two adapter methods.

Also create the equivalent CL in google3. I will merge this in when that CL is ready to go.

packages/mdc-linear-progress/README.md Outdated Show resolved Hide resolved
@rbuckheit rbuckheit force-pushed the fix/linearprogress-aria branch 2 times, most recently from 2acd374 to d1ce40e Compare November 11, 2019 23:29
Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please make sure to include BREAKING CHANGE: line in your commit message, when you squash & merge so that it'll appear nicely in our CHANGELOG :)

@abhiomkar abhiomkar changed the title fix(linearprogress-aria): Add aria attributes to linear progress bar to support screen readers fix(linear-progress): Add aria attributes to linear progress bar to support screen readers Nov 12, 2019
Adds aria attributes to MDC Linear progress to support screen readers.

BREAKING CHANGE: Adds new adapter methods to MDCLinearProgressAdapter.
@rbuckheit
Copy link
Contributor Author

LGTM.

Please make sure to include BREAKING CHANGE: line in your commit message, when you squash & merge so that it'll appear nicely in our CHANGELOG :)

Squashed and added that to the commit message :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants