feat(slider): add feature targeting for styles #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
commented
Jul 2, 2019
packages/mdc-slider/_mixins.scss
Outdated
| @include mdc-slider-track-marker_($query); | ||
| @include mdc-slider-thumb_($query); | ||
| @include mdc-slider-focus-ring_($query); | ||
| @include mdc-slider-pin_($query); |
There was a problem hiding this comment.
Note that these were all under one huge selector. I broke them up into mixins so it's easier to follow.
|
Here's the before and after output: |
35 tasks
abhiomkar
approved these changes
Jul 11, 2019
crisbeto
force-pushed
the
slider-feature-targeting
branch
from
a204677
to
1c9d297
Compare
Adds support for style feature targeting to the `slider` package. Relates to material-components#4227.
crisbeto
force-pushed
the
slider-feature-targeting
branch
from
1c9d297
to
b1d99b8
Compare
|
Addressed the feedback and rebased @abhiomkar. Can you take another look? |
Codecov Report
@@ Coverage Diff @@
## master #4871 +/- ##
=========================================
+ Coverage 98.86% 99.16% +0.3%
=========================================
Files 119 119
Lines 5650 5650
Branches 749 749
=========================================
+ Hits 5586 5603 +17
+ Misses 63 46 -17
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for style feature targeting to the
sliderpackage.Relates to #4227.