-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): Fixing bug with select menu z-index #460
fix(select): Fixing bug with select menu z-index #460
Conversation
Some elements were showing up over the select menu's pop out. e.g. radio-buttons. To demonstrate the problem, I copied demos/radio.html:72-94 into demos/select.html just after line 74. This puts a radio button right where the select menu pops up. When running the demo without the fix, you can see the radio button over the select menu. With the z-index fix, the menu appropriately pops up over the radio-button. Fixes [Issue 432](material-components#432)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 5 5
Lines 568 568
Branches 151 153 +2
=======================================
Hits 567 567
Misses 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping us out with this! LGTM. As a follow-up we've created #461 to get a more long-term strategy for this in place.
…#460) Some elements were showing up over the select menu's pop out. e.g. radio-buttons. To demonstrate the problem, I copied demos/radio.html:72-94 into demos/select.html just after line 74. This puts a radio button right where the select menu pops up. When running the demo without the fix, you can see the radio button over the select menu. With the z-index fix, the menu appropriately pops up over the radio-button. Fixes material-components#432
Some elements were showing up over the select menu's pop out. e.g.
radio-buttons. To demonstrate the problem, I copied demos/radio.html:72-94 into
demos/select.html just after line 74. This puts a radio button right
where the select menu pops up. When running the demo without the fix,
you can see the radio button over the select menu. With the z-index fix,
the menu appropriately pops up over the radio-button.
Fixes Issue 432