Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): Fixing bug with select menu z-index #460

Merged

Conversation

lukebergen
Copy link
Contributor

Some elements were showing up over the select menu's pop out. e.g.
radio-buttons. To demonstrate the problem, I copied demos/radio.html:72-94 into
demos/select.html just after line 74. This puts a radio button right
where the select menu pops up. When running the demo without the fix,
you can see the radio button over the select menu. With the z-index fix,
the menu appropriately pops up over the radio-button.

Fixes Issue 432

Some elements were showing up over the select menu's pop out. e.g.
radio-buttons. To demonstrate the problem, I copied demos/radio.html:72-94 into
demos/select.html just after line 74. This puts a radio button right
where the select menu pops up. When running the demo without the fix,
you can see the radio button over the select menu. With the z-index fix,
the menu appropriately pops up over the radio-button.

Fixes [Issue 432](material-components#432)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@lukebergen
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@codecov-io
Copy link

Codecov Report

Merging #460 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files           5        5           
  Lines         568      568           
  Branches      151      153    +2     
=======================================
  Hits          567      567           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9047d07...086c675. Read the comment docs.

Copy link
Contributor

@traviskaufman traviskaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping us out with this! LGTM. As a follow-up we've created #461 to get a more long-term strategy for this in place.

@traviskaufman traviskaufman merged commit d7784af into material-components:master Mar 31, 2017
@lukebergen lukebergen deleted the 432-fix-menu-z-index branch March 31, 2017 18:52
pgbross pushed a commit to pgbross/material-components-web that referenced this pull request Apr 5, 2017
…#460)

Some elements were showing up over the select menu's pop out. e.g.
radio-buttons. To demonstrate the problem, I copied demos/radio.html:72-94 into
demos/select.html just after line 74. This puts a radio button right
where the select menu pops up. When running the demo without the fix,
you can see the radio button over the select menu. With the z-index fix,
the menu appropriately pops up over the radio-button.

Fixes material-components#432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu not covering other controls
4 participants