fix(shape): Allow percentage based global overrides #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moog16
approved these changes
Mar 28, 2019
|
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details |
This was referenced Mar 28, 2019
abhiomkar
added a commit
that referenced
this pull request
Apr 9, 2019
(cherry picked from commit 4bf7a86)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue with overriding global shape variables with percentage values.
For example, overriding small component shape global variable would apply given radius (i.e.,
50%) to all small components (button, textfield, etc.).Whereas, default shape radius value of small component is
4px. Before this change, overriding shape global variables with percentages resulted in compilation error or wouldn't resolve the percentage value from shape literals.This change fixes it by resolving shape literals (e.g.,
small) before resolving percentage values.Refs #4140