Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon-button): Add feature targeting for styles #4536

Merged
merged 3 commits into from
Mar 25, 2019

Conversation

kfranqueiro
Copy link
Contributor

Refs #4227.

Some CSS is reordered due to splitting out ripple styles.

cc @mmalerba

@mdc-web-bot
Copy link
Collaborator

All 630 screenshot tests passed for commit 1fdea96 vs. master! 💯🎉

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update package.json file with feature-targeting dependency.

@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #4536 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4536   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         130      130           
  Lines        6279     6279           
  Branches      820      820           
=======================================
  Hits         6218     6218           
  Misses         60       60           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bfeabb...311723a. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 630 screenshot tests passed for commit ff23e84 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 630 screenshot tests passed for commit 311723a vs. master! 💯🎉

@kfranqueiro kfranqueiro merged commit a58f2d2 into master Mar 25, 2019
@kfranqueiro kfranqueiro deleted the feat/icon-button-feature-targeting branch March 25, 2019 20:57
adrianschmidt pushed a commit to Lundalogik/material-components-web that referenced this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants