Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(image-list): Add feature targeting for styles #4535

Merged
merged 5 commits into from
Mar 25, 2019
Merged

feat(image-list): Add feature targeting for styles #4535

merged 5 commits into from
Mar 25, 2019

Conversation

kfranqueiro
Copy link
Contributor

Refs #4227.

No diffs in CSS output.

cc @mmalerba

@kfranqueiro kfranqueiro mentioned this pull request Mar 22, 2019
Open
35 tasks
@mdc-web-bot
Copy link
Collaborator

All 630 screenshot tests passed for commit 8a09673 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 630 screenshot tests passed for commit d85c6ed vs. master! 💯🎉

abhiomkar
abhiomkar approved these changes Mar 25, 2019
View reviewed changes
Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. left a minor review comment.

test/scss/_feature-targeting-test.scss Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

All 630 screenshot tests passed for commit 892b89c vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Mar 25, 2019 •
edited
Loading

Codecov Report

Merging #4535 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4535   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         130      130           
  Lines        6279     6279           
  Branches      820      820           
=======================================
  Hits         6218     6218           
  Misses         60       60           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e80ac0c...62a12c5. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 630 screenshot tests passed for commit c7290db vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 630 screenshot tests passed for commit 62a12c5 vs. master! 💯🎉

@kfranqueiro kfranqueiro merged commit 0bfeabb into master Mar 25, 2019
adrianschmidt pushed a commit to Lundalogik/material-components-web that referenced this pull request Mar 29, 2019
@kfranqueiro
feat(image-list): Add feature targeting for styles (material-componen…
1046258 
…ts#4535)

(cherry picked from commit 0bfeabb)
@kfranqueiro kfranqueiro deleted the feat/image-list-feature-targeting branch April 2, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@abhiomkar abhiomkar abhiomkar approved these changes

Assignees

@abhiomkar abhiomkar

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kfranqueiro @mdc-web-bot @codecov-io @abhiomkar @mmalerba @googlebot