This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Make TS easier to wrap #4407
refactor: Make TS easier to wrap #4407
Changes from 74 commits
d4320a3
64d44bd
4b8d7f1
9395509
20b4709
db04534
73525f7
80223a1
7e85e42
ff41340
482c6e1
e9e0e33
a080cda
5ef72ad
8c5cde8
7a35f8b
2874cb4
2efc895
86a31ce
103f125
173f202
7ed6123
d679b39
ed47614
83300c5
ffb24c3
f765918
ab90fa5
94fd587
16764a1
5bdfcfb
3d41e71
c015434
c0bebff
611d78d
7558e6f
031da72
577bec1
0831eed
725b7fe
17a6945
77ce604
4c1138f
da08b76
c3a26b3
66d615f
3be46ee
835031a
361edfe
1e9496d
c1bec4b
93c7bf3
c4c639d
8fae93f
d1fe4c4
694516c
d86e67a
31e637e
60a75a8
c289e4b
d877bc3
6f9ab9f
1b8e912
08cd3bb
1e68882
03db3ea
9406e0c
07bc5ea
0f1a813
928628c
0bfcf50
7f6693f
eb36503
a09f608
56a0650
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In master, animation also exports
transformStyleProperties
, which seems to have disappeared from the package on the TS branch?const transformStyleProperties = ['transform', 'WebkitTransform', 'MozTransform', 'OTransform', 'MSTransform'];
It seems very unlikely that anything external would rely on this though... (We relied on it in linear-progress but it no longer does; it uses
getCorrectPropertyName
now instead.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, I guess that's technically a breaking change...
Should I mirror this with a PR in master to ensure it ends up in the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible and reasonable to do that in master? (I guess it comes down to being able to make a similar change to linear-progress in master.)