Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auto-init): Convert JS to TypeScript #4395
feat(auto-init): Convert JS to TypeScript #4395
Changes from all commits
4e99e51
e00153b
86a52f0
e9690cf
6b6f7fb
78e0b7f
50f256c
cbd6218
eb01f18
59adfbc
8aae7e3
3c83f31
5d3f489
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the TODO above this obsolete? (Like, would our build actually fail without an
attachTo
given the typings above? Plus we're using tslint now to reuse the Google configuration.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately TypeScript won't catch that because it doesn't do static type checking.
See microsoft/TypeScript#14600.
attachTo()
in theComponent
interface is only there to make TS happy when we try to callConstructor.attachTo()
inmdcAutoInit()
. It doesn't verify thatstatic attachTo()
exists on classes passed toregister()
.It does, however, verify that the required constructor signature exists (via
new<F...>()
) on classes passed toregister()
.