Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-init): Convert JS to TypeScript #4395

Merged
merged 13 commits into from
Feb 14, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions packages/mdc-auto-init/index.js → packages/mdc-auto-init/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,18 @@
* THE SOFTWARE.
*/

// tslint:disable:only-arrow-functions

const registry = Object.create(null);

const CONSOLE_WARN = console.warn.bind(console);
const CONSOLE_WARN = console.warn.bind(console); // tslint:disable-line:no-console

function _emit(evtType, evtData, shouldBubble = false) {
function _emit(evtType: string, evtData: object, shouldBubble = false) {
let evt;
if (typeof CustomEvent === 'function') {
evt = new CustomEvent(evtType, {
detail: evtData,
bubbles: shouldBubble,
detail: evtData,
});
} else {
evt = document.createEvent('CustomEvent');
Expand All @@ -41,23 +43,25 @@ function _emit(evtType, evtData, shouldBubble = false) {
}

/**
* Auto-initializes all mdc components on a page.
* Auto-initializes all MDC components on a page.
*/
export default function mdcAutoInit(root = document, warn = CONSOLE_WARN) {
function mdcAutoInit(root = document, warn = CONSOLE_WARN) {
const components = [];
const nodes = root.querySelectorAll('[data-mdc-auto-init]');
for (let i = 0, node; (node = nodes[i]); i++) {
const nodes: HTMLElement[] = [].slice.call(root.querySelectorAll<HTMLElement>('[data-mdc-auto-init]'));

for (const node of nodes) {
const ctorName = node.dataset.mdcAutoInit;
if (!ctorName) {
throw new Error('(mdc-auto-init) Constructor name must be given.');
}

const Ctor = registry[ctorName];
const Ctor = registry[ctorName]; // tslint:disable-line:variable-name
if (typeof Ctor !== 'function') {
throw new Error(
`(mdc-auto-init) Could not find constructor in registry for ${ctorName}`);
}

// @ts-ignore
acdvorak marked this conversation as resolved.
Show resolved Hide resolved
if (node[ctorName]) {
warn(`(mdc-auto-init) Component already initialized for ${node}. Skipping...`);
continue;
Expand All @@ -66,10 +70,10 @@ export default function mdcAutoInit(root = document, warn = CONSOLE_WARN) {
// TODO: Should we make an eslint rule for an attachTo() static method?
const component = Ctor.attachTo(node);
Object.defineProperty(node, ctorName, {
configurable: true,
enumerable: false,
value: component,
writable: false,
enumerable: false,
configurable: true,
});
components.push(component);
}
Expand All @@ -78,7 +82,8 @@ export default function mdcAutoInit(root = document, warn = CONSOLE_WARN) {
return components;
}

mdcAutoInit.register = function(componentName, Ctor, warn = CONSOLE_WARN) {
// tslint:disable-next-line:variable-name
acdvorak marked this conversation as resolved.
Show resolved Hide resolved
mdcAutoInit.register = function(componentName: string, Ctor: Function, warn = CONSOLE_WARN) {
acdvorak marked this conversation as resolved.
Show resolved Hide resolved
if (typeof Ctor !== 'function') {
throw new Error(`(mdc-auto-init) Invalid Ctor value ${Ctor}. Expected function`);
}
Expand All @@ -90,10 +95,12 @@ mdcAutoInit.register = function(componentName, Ctor, warn = CONSOLE_WARN) {
registry[componentName] = Ctor;
};

mdcAutoInit.deregister = function(componentName) {
mdcAutoInit.deregister = function(componentName: string) {
delete registry[componentName];
};

mdcAutoInit.deregisterAll = function() {
Object.keys(registry).forEach(this.deregister, this);
};

export {mdcAutoInit as default, mdcAutoInit};
3 changes: 3 additions & 0 deletions packages/mdc-auto-init/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,8 @@
"repository": {
"type": "git",
"url": "https://github.com/material-components/material-components-web.git"
},
"dependencies": {
"@material/base": "^0.41.0"
acdvorak marked this conversation as resolved.
Show resolved Hide resolved
}
}
2 changes: 1 addition & 1 deletion scripts/webpack/js-bundle-factory.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ class JsBundleFactory {
bundleName: 'main-js-a-la-carte',
chunks: {
animation: getAbsolutePath('/packages/mdc-animation/index.ts'),
autoInit: getAbsolutePath('/packages/mdc-auto-init/index.js'),
autoInit: getAbsolutePath('/packages/mdc-auto-init/index.ts'),
base: getAbsolutePath('/packages/mdc-base/index.ts'),
checkbox: getAbsolutePath('/packages/mdc-checkbox/index.ts'),
chips: getAbsolutePath('/packages/mdc-chips/index.ts'),
Expand Down