-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): Convert JS to TypeScript #4386
Merged
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9313e66
feat(select): Convert JS to TypeScript
acdvorak 135e09d
WIP: Add comment
acdvorak bc8bf0d
WIP: Fix compiler errors
acdvorak fb0b996
WIP: Make Istanbul happy
acdvorak 7a7d960
Merge branch 'feat/typescript--select' of github.com:material-compone…
acdvorak 91f5975
WIP: Change `MDCList.listElements` from `HTMLElement[]` back to `Elem…
acdvorak b50a47a
WIP: `extends CustomEvent<MenuItemEventDetail>`
acdvorak 01edf0f
WIP: Remove Closure annotations
acdvorak a286663
WIP: Initialize `savedTabIndex_` inline
acdvorak 5facf07
WIP: Remove unnecessary `@material/textfield` dependency from `packag…
acdvorak 7b625f6
Merge remote-tracking branch 'origin/feat/typescript' into feat/types…
acdvorak f6de964
Merge remote-tracking branch 'origin/feat/typescript' into feat/types…
acdvorak 4fa0e79
WIP: Update filename to `.ts` in `js-bundle-factory.js`
acdvorak dc34eb6
Merge remote-tracking branch 'origin/feat/typescript' into feat/types…
acdvorak de38dd6
WIP: Revert argument rename in `MDCComponent.emit()`
acdvorak 01b22be
WIP: Address review comments
acdvorak ebbbbb9
WIP: Re-indent
acdvorak a236050
WIP: Address review comments
acdvorak 1e8b7e2
WIP: Throw an error if required subelements are missing
acdvorak a0cce8c
WIP: Fix `TouchEvent` `clientX` bug
acdvorak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I overlooked this in the original Menu PR but I found the
Default
here confusing. Unsure whether #4407 could leave room for resolving this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a hard time figuring out what to call this type, so I'm definitely open to suggestions.
MenuItemEvent
is only used by foundation and adapterDefaultMenuItemEvent
is only used by the component, and has an additional property on itsdetail
objectWhat would you prefer to call it?