Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notched-outline): Convert JS to TypeScript #4375

Merged
merged 5 commits into from
Feb 8, 2019
Merged

feat(notched-outline): Convert JS to TypeScript #4375

merged 5 commits into from
Feb 8, 2019

Conversation

acdvorak
Copy link
Contributor

@acdvorak acdvorak commented Feb 8, 2019

Refs #4225

acdvorak
acdvorak commented Feb 8, 2019
View reviewed changes
packages/mdc-notched-outline/index.ts

import MDCNotchedOutlineAdapter from './adapter';
import MDCNotchedOutlineFoundation from './foundation';
import {MDCNotchedOutlineFoundation} from './foundation';
import {MDCFloatingLabelFoundation} from '@material/floating-label/index';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on #4374

@kfranqueiro kfranqueiro mentioned this pull request Feb 8, 2019
Closed
45 tasks
@codecov-io
Copy link

codecov-io commented Feb 8, 2019 •
edited
Loading

Codecov Report

Merging #4375 into feat/typescript will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat/typescript    #4375      +/-   ##
===================================================
+ Coverage            98.64%   98.65%   +<.01%     
===================================================
  Files                   93       93              
  Lines                 5916     5928      +12     
  Branches               796      799       +3     
===================================================
+ Hits                  5836     5848      +12     
  Misses                  79       79              
  Partials                 1        1
Impacted Files Coverage Δ
packages/mdc-notched-outline/foundation.ts 100% <100%> (ø)
packages/mdc-notched-outline/index.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50eb8c7...c7987fe. Read the comment docs.

@acdvorak acdvorak mentioned this pull request Feb 8, 2019
Merged
moog16
moog16 suggested changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@moog16 moog16 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update js-bundle-factory

packages/mdc-notched-outline/foundation.ts Show resolved Hide resolved
packages/mdc-notched-outline/index.ts Outdated Show resolved Hide resolved
@moog16
Copy link
Contributor

moog16 commented Feb 8, 2019

also update js-bundle-factory

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit c7987fe vs. feat/typescript! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 23728f9 vs. feat/typescript! 💯🎉

@acdvorak acdvorak merged commit 197f7fe into feat/typescript Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moog16 moog16 moog16 approved these changes

@kfranqueiro kfranqueiro Awaiting requested review from kfranqueiro

Assignees

@kfranqueiro kfranqueiro

@moog16 moog16

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@acdvorak @codecov-io @moog16 @mdc-web-bot @kfranqueiro @googlebot