Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @octokit/rest to the latest version 🚀 #4100

Merged
merged 6 commits into from
Dec 5, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Nov 20, 2018

The devDependency @octokit/rest was updated from 15.18.0 to 16.0.1.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Release Notes for v16.0.1

To upgrade to v16, make sure you have the latest v15 release installed first:

npm install @octokit/[email protected]

Now run the tests and look for DEPRECATED messages in the logs. Once you see no more deprecations, upgrading to v16 should cause no problems.

BREAKING CHANGES

  • all previously deprecated methods have been removed

  • preview headers that are not required to use an API have been removed

  • .gitdata.getTags() has been removed. Use .gitdata.listRefs({namespace: tags}) instead

  • Methods for undocumented endpoints have been removed.

    Instead of client.users.getById({id}) use client.request({method: GET, url: /user/:id, id})
    Instead of client.repos.getById({id}) use client.request({method: GET, url: /repositories/:id, id})

  • octokit.enterprise.* methods have been removed. They will be moved into a plugin like https://github.com/octokit/plugin-scim.js

  • routes: the milestone parameter is no longer validated using a regex as it cannot be derived from octokit/routes

  • travis: dropped support for node 4

  • error.message is no longer a JSON string containing GitHub’s error message. Instead the JSON is parsed internally and error properties are assigned with its value. This is not technically a breaking change but a bug fix, but as this bug was around for a long time and plenty of apps depend on JSON.parse(error.message) to be working, we treat it as a breaking change by way of precaution

  • error.status is now the response status code number. The status text is no longer returned

Features

Bug Fixes

  • routes: remove validation for milestone parameter as it cannot be derived from octokit/routes (4d04d17)
  • only set preview headers required to use the API (1628821)
  • parse JSON from GitHub error messages (dd6306e)

Continuous Integration

  • travis: drop tests in node 4 & 9, test in node 10 (ad8b1e5)

Bug Fixes in v16.0.1

  • typescript: Adding return types (18ac5bf), closes #1116
  • typescript: Adding the noImplicitAny flag to validate:ts (ef4d35a)
  • typescript: Github.plugin is a static method, not an instance method (01763bf)
  • typescript: include a header object when transforming Content-Type and Content-Length to headers.content-type and headers.content-length (0b9cc37)

Thanks @mamodom for your great help with these Typescript fixes 💐

Commits

The new version differs by 86 commits.

  • 01763bf fix(typescript): Github.plugin is a static method, not an instance method
  • ef4d35a fix(typescript): Adding the noImplicitAny flag to validate:ts
  • 18ac5bf fix(typescript): Adding return types
  • 0b9cc37 fix(typescript): include a header object when transforming Content-Type and Content-Length to headers.content-type and headers.content-length
  • ebea33d build: remove obsolete artefacts for flow types
  • 9021da4 build(typescript): date response header
  • 9efa49e docs(README): typo in code example
  • 09c2ba8 build(package): next dist-tag
  • 138f08d build: TypeScript typing definitions for v16 updates (#1113)
  • 506dc3a docs: wrong variable name in example (#1112)
  • 46a1ee9 build(package): remove engine field
  • 82a4678 ci(travis): test node_modules folder size is < 1mb
  • 73207c7 build: package-lock.json
  • c597bf7 build(package): update @octokit/request
  • ed90210 build(package-lock): initial version

There are 86 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@codecov-io
Copy link

codecov-io commented Nov 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@167add5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4100   +/-   ##
=========================================
  Coverage          ?   98.43%           
=========================================
  Files             ?      126           
  Lines             ?     5616           
  Branches          ?      753           
=========================================
  Hits              ?     5528           
  Misses            ?       88           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167add5...30eb3d0. Read the comment docs.

greenkeeper bot added a commit that referenced this pull request Nov 26, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 26, 2018

  • The devDependency @octokit/rest was updated from 15.18.0 to 16.0.3.

Update to this version instead 🚀

Release Notes for v16.0.3

Bug Fixes

  • aliasing octokit.gitdataoctokit.git, octokit.authorizationoctokit.oauthAuthorizations, octokit.pullRequestsoctokit.pulls (0766d51)

Thanks to @hipstersmoothie for their help 💐

Commits

The new version differs by 11 commits.

  • 0766d51 fix: aliasing octokit.gitdataoctokit.git, octokit.authorizationoctokit.oauthAuthorizations, octokit.pullRequestsoctokit.pulls
  • 05f3f7b build: routes.json
  • abcadaa build: generate routes.json without manually mapping scopes
  • 367c710 test: octokit.pulls.*
  • db3074c build(types): remove obsolete code (#1122)
  • 72e26d2 build: routes
  • 2a7343f chore(package): update lockfile package-lock.json
  • 0b13a63 chore(package): update @octokit/routes to version 15.2.0
  • b774ade chore(package): update lockfile package-lock.json
  • 31185c9 fix(package): update @octokit/request to version 2.1.2
  • d926a8f docs(README): Change github.paginate to octokit.paginate (#1126)

See the full diff

greenkeeper bot added a commit that referenced this pull request Nov 26, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 26, 2018

  • The devDependency @octokit/rest was updated from 15.18.0 to 16.0.4.

Update to this version instead 🚀

Release Notes for v16.0.4

Bug Fixes

  • package: remove node-fetch dependency (1d2ed27)

Merci @pvdlg for their help 💐

Commits

The new version differs by 5 commits.

  • 62ccd3f build: replace http:// with https:// in lock file
  • 705155b build: package lock file
  • 1d2ed27 fix(package): remove node-fetch dependency
  • d235f83 refactor: replace node-fetch with @octokit/request
  • 6713e41 build(package): publish to @latest

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 26, 2018

  • The devDependency @octokit/rest was updated from 15.18.0 to 16.0.5.

Update to this version instead 🚀

Release Notes for v16.0.5

16.0.5 (2018-11-26)

Bug Fixes

  • typescript: octokit.authenticate definitions using overloads (23ca22d)
Commits

The new version differs by 2 commits.

  • 23ca22d fix(typescript): octokit.authenticate definitions using overloads
  • b152011 refactor: harmonize variable naming of the Octokit client variable

See the full diff

greenkeeper bot added a commit that referenced this pull request Nov 26, 2018
greenkeeper bot added a commit that referenced this pull request Nov 28, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 28, 2018

  • The devDependency @octokit/rest was updated from 15.18.0 to 16.1.0.

Update to this version instead 🚀

Release Notes for v16.1.0

16.1.0 (2018-11-28)

Features

Commits

The new version differs by 4 commits.

  • 5851ea8 build: package lock file
  • 7497080 feat(package): error.request is now set to the request options that resulted in an error, via @octokit/[email protected]
  • fde8194 docs(README): don't forget await! (#1142)
  • ac814bc docs(README): typo

See the full diff

@kfranqueiro
Copy link
Contributor

I'd like @acdvorak to take a look at this when he gets back. We use this API for screenshot test status updates and reports, IIUC.

I took a look at this last week and the one breaking change that I could find that might affect us is that pullRequests.getAll becomes pullRequests.list. However, I also couldn't immediately find anything evidently broken in the tests run on this branch, when I would expect it to break due to the moved API.

@mdc-web-bot
Copy link
Collaborator

All 691 screenshot tests passed for commit 30eb3d0 vs. master! 💯🎉

@acdvorak
Copy link
Contributor

acdvorak commented Dec 5, 2018

  • Bumped @octokit/rest to version 16.1.0
  • Migrated to new API methods:
    • pullRequests.getAll()pulls.list()
    • pullRequests.get()pulls.get()

@acdvorak acdvorak merged commit 6739ea0 into master Dec 5, 2018
@acdvorak acdvorak deleted the greenkeeper/@octokit/rest-16.0.1 branch December 5, 2018 23:29
adrianschmidt pushed a commit to Lundalogik/material-components-web that referenced this pull request Jan 4, 2019
The devDependency [@octokit/rest](https://github.com/octokit/rest.js) was updated from `15.9.4` to `16.1.0`.

(cherry picked from commit 6739ea0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants