Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): Release focus after style changes on close #4069

Merged
merged 10 commits into from
Nov 21, 2018
Merged

fix(dialog): Release focus after style changes on close #4069

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
52cd2dc
fix(dialog): Release focus after style changes on close
abhiomkar Nov 8, 2018
928d848
fix(dialog): Move releaseFocus to get executed only on close
abhiomkar Nov 13, 2018
6d467eb
Merge branch 'master' into fix/dialog_focus_voiceover
abhiomkar Nov 20, 2018
ccb23aa
fix(dialog): Updated README
abhiomkar Nov 20, 2018
6800ea7
fix(dialog): Updated unit tests.
abhiomkar Nov 20, 2018
b95fec6
Merge branch 'master' of github.com:material-components/material-comp…
abhiomkar Nov 20, 2018
d813e87
Merge remote-tracking branch 'origin/fix/dialog_focus_voiceover' into…
abhiomkar Nov 20, 2018
be8a2fb
Merge branch 'master' into fix/dialog_focus_voiceover
abhiomkar Nov 20, 2018
2e6c1ee
Merge branch 'master' into fix/dialog_focus_voiceover
abhiomkar Nov 21, 2018
02c8f11
Merge branch 'master' into fix/dialog_focus_voiceover
abhiomkar Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mdc-dialog/foundation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,13 @@ class MDCDialogFoundation extends MDCFoundation {

this.isOpen_ = false;
this.adapter_.notifyClosing(action);
this.adapter_.releaseFocus();
this.adapter_.addClass(cssClasses.CLOSING);
this.adapter_.removeClass(cssClasses.OPEN);
this.adapter_.removeBodyClass(cssClasses.SCROLL_LOCK);

clearTimeout(this.animationTimer_);
this.animationTimer_ = setTimeout(() => {
this.adapter_.releaseFocus();
this.handleAnimationTimerEnd_();
this.adapter_.notifyClosed(action);
}, numbers.DIALOG_ANIMATION_CLOSE_TIME_MS);
Expand Down