-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shape): Added new Shape APIs #3541
Merged
Merged
Changes from 21 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
789e631
feat(shape): added shape APIs and updated README.
abhiomkar 645a644
feat(shape): Updated shape API to accept component height instead of …
abhiomkar 93758b9
feat(shape): Removed old shape demos from here
abhiomkar fdba967
feat(shape): Updated shape categories
abhiomkar e15d2cc
feat(shape): Updated shape pill resolve functions
abhiomkar 3a1de82
feat(shape): Remove height info from shapes
abhiomkar 98dafb4
feat(shape): Updated README and mixins
abhiomkar d2f8495
feat(shape): Use prop-value function when validating radius
abhiomkar 2b8e864
feat(shape): Simplified shape mixin & functions
abhiomkar dc4be29
feat(shape): Updates to README
abhiomkar 4585758
feat(shape): Added docs for functions.scss
abhiomkar 9f3a6dd
feat(shape): Minor doc updates
abhiomkar d68700d
feat(shape): Updates to shape category value
abhiomkar 82acafe
Merge branch 'feat/shape' into feat/shape_api
abhiomkar 68b4794
feat(shape): Updated travis yml to include shape feat branch
abhiomkar 2047412
feat(shape): Updated README for functions
abhiomkar 71c1e50
feat(shape): Added support for percentage
abhiomkar 2c9d160
feat(shape): Updated docs for percentage radius changes
abhiomkar d100ff1
feat(shape): Updated is-valid radius function for percentage radius
abhiomkar f85d500
feat(shape): Updated README to mention it supports only rounded
abhiomkar 637fa38
feat(shape): Renamed global variables to include *-surface-* term
abhiomkar faa032c
feat(shape): Reorganized README
abhiomkar 3a3afc6
feat(shape): Code comment for extracting number from percentage
abhiomkar b3067cd
feat(list): Changes for review comments
abhiomkar b5dc384
feat(shape): Made prop-value mixin private
abhiomkar 6241ada
fix(shape): changes for review comments
abhiomkar b55ee00
fix(shape): changes for review comments
abhiomkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline: let's bring this back in line with the readme standards/template.