fix(select): Only add line ripple listeners when line ripple is present #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
reviewed
Aug 29, 2018
packages/mdc-select/index.js
Outdated
| @@ -287,7 +290,9 @@ class MDCSelect extends MDCComponent { | |||
| const targetClientRect = evt.target.getBoundingClientRect(); | |||
| const xCoordinate = evt.clientX; | |||
| const normalizedX = xCoordinate - targetClientRect.left; | |||
| this.lineRipple_.setRippleCenter(normalizedX); | |||
| if (this.lineRipple_) { | |||
There was a problem hiding this comment.
This would never not be true since we're not hooking up the listener to this method if line ripple doesn't exist, right?
|
All 349 screenshot tests passed for commit 0028c22 vs. |
kfranqueiro
approved these changes
Aug 29, 2018
|
All 349 screenshot tests passed for commit e0f75f3 vs. |
Codecov Report
@@ Coverage Diff @@
## master #3470 +/- ##
=========================================
Coverage ? 98.42%
=========================================
Files ? 119
Lines ? 5021
Branches ? 614
=========================================
Hits ? 4942
Misses ? 79
Partials ? 0
Continue to review full report at Codecov.
|
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Sep 25, 2018
…nt (material-components#3470) (cherry picked from commit 453b5c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the line ripple logic in the
selectto only add the event listeners or updates if the line ripple element exists.