-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(drawer): New sass mixin to set z-index #3453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If our only intended supported use case for this is to support the drawer clipped by the top app bar, should we implement a clipped class or mixin instead which sets the z-index to a more appropriate value (and give it another variable), rather than exposing a mixin to set any z-index?
I'm also not sure we're really documenting how to structure clipped drawer in the readme.
Right now we're not opinionated about clipped being variant because it requires applying additional CSS to external elements. Clipped variant also has open issue of extra space being left by auto dismissible top app bar. We can definitely document in future. Created #3456 |
All 349 screenshot tests passed for commit fa682db vs. |
All 349 screenshot tests passed for commit 9325626 vs. |
All 349 screenshot tests passed for commit a4afc5b vs. |
No description provided.