Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drawer): New sass mixin to set z-index #3453

Merged
merged 3 commits into from
Aug 28, 2018
Merged

Conversation

abhiomkar
Copy link
Collaborator

No description provided.

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If our only intended supported use case for this is to support the drawer clipped by the top app bar, should we implement a clipped class or mixin instead which sets the z-index to a more appropriate value (and give it another variable), rather than exposing a mixin to set any z-index?

I'm also not sure we're really documenting how to structure clipped drawer in the readme.

@abhiomkar
Copy link
Collaborator Author

Right now we're not opinionated about clipped being variant because it requires applying additional CSS to external elements. Clipped variant also has open issue of extra space being left by auto dismissible top app bar.

We can definitely document in future. Created #3456

@mdc-web-bot
Copy link
Collaborator

All 349 screenshot tests passed for commit fa682db vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 349 screenshot tests passed for commit 9325626 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 349 screenshot tests passed for commit a4afc5b vs. master! 💯🎉

@abhiomkar abhiomkar merged commit cf3084f into master Aug 28, 2018
@abhiomkar abhiomkar deleted the feat/drawer/zindex branch August 28, 2018 21:48
@jamesmfriedman jamesmfriedman mentioned this pull request Sep 26, 2018
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants