Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(top-app-bar): Fix testdouble warning about using both stub & verify. #2793

Merged
merged 1 commit into from
May 23, 2018

Conversation

abhiomkar
Copy link
Collaborator

Moved number of calls check to when() on stubbing using "times".

Follow up to PR: #2751

Moved number of calls check using 0m0.00s 0m0.00s
0m0.00s 0m0.00s to when() stubbing.
Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick turnaround.

@codecov-io
Copy link

Codecov Report

Merging #2793 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2793   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          98       98           
  Lines        4231     4231           
  Branches      538      538           
=======================================
  Hits         4167     4167           
  Misses         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0f614...fb1c7cf. Read the comment docs.

@abhiomkar abhiomkar merged commit d79af08 into master May 23, 2018
@kfranqueiro kfranqueiro deleted the fix_topappbar_testdouble_warning_issue2721 branch August 1, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants