Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(base): Ensure this.root_ is available within getDefaultFoundation() #279

Merged
merged 2 commits into from
Feb 10, 2017
Merged

fix(base): Ensure this.root_ is available within getDefaultFoundation() #279

merged 2 commits into from
Feb 10, 2017

Conversation

traviskaufman
Copy link
Contributor

Fixes #242

@traviskaufman traviskaufman force-pushed the fix/make-this-root-available-within-getDefaultFoundation branch from d7aef9b to 9740a61 Compare February 8, 2017 19:52
yeelan0319
yeelan0319 approved these changes Feb 10, 2017
View reviewed changes
Copy link
Contributor

@yeelan0319 yeelan0319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@traviskaufman traviskaufman merged commit c637cb6 into master Feb 10, 2017
@traviskaufman traviskaufman deleted the fix/make-this-root-available-within-getDefaultFoundation branch February 10, 2017 19:22
cristobalchao pushed a commit that referenced this pull request Feb 24, 2017
@traviskaufman
fix(base): Ensure this.root_ is available within getDefaultFoundation…
fc57a6e 
…() (#279)

Fixes #242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeelan0319 yeelan0319 yeelan0319 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traviskaufman @yeelan0319