Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chips): Update to guidance #2601

Merged
merged 5 commits into from
Apr 19, 2018
Merged

Conversation

williamernest
Copy link
Contributor

Fixes: #2479
Adds proper typography style.
Changes references to black color to use on-surface

@bonniezhou bonniezhou self-assigned this Apr 19, 2018
Copy link
Contributor

@bonniezhou bonniezhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still using the text-primary-on-dark variables? If we are we probably wanna change white-> text-primary-on-dark, and black -> text-primary-on-light as well in the mdc-chip-fill-color-accessible mixin. Otherwise LGTM!

@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #2601 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2601   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          98       98           
  Lines        4198     4198           
  Branches      533      533           
=======================================
  Hits         4143     4143           
  Misses         55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be9d96...70ce944. Read the comment docs.

@williamernest williamernest merged commit c529cea into master Apr 19, 2018
@williamernest williamernest deleted the fix/chips/update-to-guidance branch April 19, 2018 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants