fix(floating-label): achieved 100% test coverage #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
suggested changes
Apr 6, 2018
| const {component} = setupTest(); | ||
| component.foundation_.shake = td.func(); | ||
| component.shake(true); | ||
| td.verify(component.shake(true), {times: 1}); |
There was a problem hiding this comment.
This is literally verifying the thing you just called (and is probably not even operating through td since it's not a mock?). I think this is supposed to be foundation?
There was a problem hiding this comment.
Ah! Yes...I'm supposed to be testing the foundation like in the subsequent tests. Thanks for catching.
Codecov Report
@@ Coverage Diff @@
## master #2523 +/- ##
==========================================
+ Coverage 98.71% 98.85% +0.14%
==========================================
Files 103 103
Lines 4111 4111
Branches 516 516
==========================================
+ Hits 4058 4064 +6
+ Misses 53 47 -6
Continue to review full report at Codecov.
|
kfranqueiro
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been bothering me that I didn't get to 100% test coverage before, so here we are!