Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-field): Remove press ripple effect #2419

Merged
merged 2 commits into from
Mar 20, 2018

Conversation

kfranqueiro
Copy link
Contributor

This removes the press ripple effect from Text Field Box and Outlined Text Field.

In the case of outlined, we can remove the use of MDCRipple entirely, as we were only using the press state previously.

In the case of box, we still want the other states, so this switches from using the basic mixin to apply all states, to using the specific states mixins for only the states we want.

Fixes #2354.

@codecov-io
Copy link

codecov-io commented Mar 16, 2018

Codecov Report

Merging #2419 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2419      +/-   ##
==========================================
- Coverage   98.86%   98.86%   -0.01%     
==========================================
  Files         101      101              
  Lines        4151     4149       -2     
  Branches      531      529       -2     
==========================================
- Hits         4104     4102       -2     
  Misses         47       47
Impacted Files Coverage Δ
packages/mdc-textfield/index.js 96.1% <100%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ae77c...167a1e2. Read the comment docs.

@kfranqueiro kfranqueiro requested review from moog16 and removed request for bonniezhou March 20, 2018 12:18
@kfranqueiro kfranqueiro assigned moog16 and unassigned bonniezhou Mar 20, 2018
Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the CSS out and README as well.

LGTM

@acdvorak acdvorak self-assigned this Mar 20, 2018
Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kfranqueiro kfranqueiro merged commit e207f0f into master Mar 20, 2018
@kfranqueiro kfranqueiro deleted the fix/text-field/no-ripple branch March 20, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants