Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): icon in rtl should have margin right flipped. #2346

Merged
merged 4 commits into from
Mar 6, 2018
Merged

fix(button): icon in rtl should have margin right flipped. #2346

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f54fe92
fix(button): icon in rtl should have margin right flipped.
Mar 5, 2018
fe063bc
fix(button): unscrewing myself.
Mar 6, 2018
111e6ec
fix(button): wrong version rtl.
Mar 6, 2018
ac4dc6d
Merge branch 'master' into button/rtl
aprigogin Mar 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/mdc-button/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

@import "@material/elevation/mixins";
@import "@material/ripple/mixins";
@import "@material/rtl/mixins";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add rtl to dependencies in button's package.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@import "@material/theme/functions";
@import "@material/theme/mixins";
@import "@material/typography/mixins";
Expand Down Expand Up @@ -127,10 +128,11 @@
}

@mixin mdc-button__icon_ {
@include mdc-rtl-reflexive-box(margin, right, 8px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove the margin-right: 8px line below (line 136)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, my bad.


display: inline-block;
width: 18px;
height: 18px;
margin-right: 8px;
font-size: 18px;
line-height: inherit;
vertical-align: top;
Expand Down
1 change: 1 addition & 0 deletions packages/mdc-button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"dependencies": {
"@material/elevation": "^0.28.0",
"@material/ripple": "^0.32.0",
"@material/rtl": "^0.30.0",
"@material/theme": "^0.30.0",
"@material/typography": "^0.28.0"
}
Expand Down