Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): Remove list CSS, and use mdc-list styles directly #2065

Merged
merged 2 commits into from
Jan 24, 2018
Merged

fix(select): Remove list CSS, and use mdc-list styles directly #2065

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dd29a6
fix(select): Remove list CSS, and use mdc-list styles directly
lynnmercier Jan 24, 2018
854b87b
Merge branch 'master' into fix/select/use-list-directly
lynnmercier Jan 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions packages/mdc-select/mdc-select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,64 +219,6 @@ $mdc-select-menu-transition: transform 180ms $mdc-animation-standard-curve-timin

// postcss-bem-linter: end

.mdc-select__menu {
.mdc-list-item {
@include mdc-typography(subheading2);
@include mdc-theme-prop(color, text-secondary-on-light);

&[aria-selected="true"] {
@include mdc-theme-prop(color, text-primary-on-light);
}

@include mdc-theme-dark(".mdc-select") {
@include mdc-theme-prop(color, text-secondary-on-dark);

&[aria-selected="true"] {
@include mdc-theme-prop(color, text-primary-on-dark);
}
}

// Styles to override mdc-ripple-radius from mdc-list, which causes display glitches in Chrome
// (See https://github.com/material-components/material-components-web/pull/1737#issuecomment-351105800)
@include mdc-ripple-radius(50%);

&::before,
&::after {
border-radius: 0;
}
}

.mdc-list-group,
.mdc-list-group > .mdc-list-item:first-child {
margin-top: 12px;
}

.mdc-list-group {
@include mdc-theme-prop(color, text-hint-on-light);

font-weight: normal;

.mdc-list-item {
@include mdc-theme-prop(color, text-primary-on-light);
}
}

@include mdc-theme-dark(".mdc-select") {
.mdc-list-group {
@include mdc-theme-prop(color, text-hint-on-dark);

.mdc-list-item {
@include mdc-theme-prop(color, text-primary-on-dark);
}
}
}
}

// height for option elements cannot be controlled
// with CSS. Use the font-size rule instead.

// postcss-bem-linter: end

.mdc-select-scroll-lock {
overflow: hidden;
}