Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(card): Add primary action element with hover, focused, and pressed states #2039

Merged
merged 99 commits into from
Feb 6, 2018
Merged

feat(card): Add primary action element with hover, focused, and pressed states #2039

merged 99 commits into from
Feb 6, 2018

Commits on Jan 18, 2018

  1. chore(card): Remove layouts (WIP)

    @acdvorak
    acdvorak committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    f9e256f View commit details
    Browse the repository at this point in the history

  2. WIP: Add __action-buttons and __action-icons classes

    @acdvorak
    acdvorak committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    d7c537f View commit details
    Browse the repository at this point in the history

  3. WIP: Refactoring

    @acdvorak
    acdvorak committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    1cbe378 View commit details
    Browse the repository at this point in the history

  4. WIP: Add __media classes, rename other classes

    @acdvorak
    acdvorak committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    d3bace3 View commit details
    Browse the repository at this point in the history

  5. WIP: Rename classes

    @acdvorak
    acdvorak committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    51fa44d View commit details
    Browse the repository at this point in the history

  6. WIP: Refactoring and add "Share" action icon

    @acdvorak
    acdvorak committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    d363411 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2018

  1. feat(base): shouldBubble now defaults to true 

    BREAKING CHANGE: The `shouldBubble` param of `MDCComponent.emit()` now defaults to `true` instead of `false`.
    @acdvorak
    acdvorak committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    4c08741 View commit details
    Browse the repository at this point in the history

  2. WIP: Spec alignment

    @acdvorak
    acdvorak committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    aac2ca2 View commit details
    Browse the repository at this point in the history

  3. WIP: Add example of a "small" card

    @acdvorak
    acdvorak committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    3604c49 View commit details
    Browse the repository at this point in the history

  4. WIP: Add music album example

    @acdvorak
    acdvorak committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    da234a4 View commit details
    Browse the repository at this point in the history

  5. WIP: Rename class, reorder styles

    @acdvorak
    acdvorak committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    059a325 View commit details
    Browse the repository at this point in the history

  6. WIP: Add margin between buttons and icons

    @acdvorak
    acdvorak committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    b6a5993 View commit details
    Browse the repository at this point in the history

  7. WIP: Start updating README

    @acdvorak
    acdvorak committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    e27c1c1 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2018

  1. Merge branch 'master' into chore/card/remove-layouts

    @acdvorak
    acdvorak committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    e41ddbf View commit details
    Browse the repository at this point in the history

  2. WIP: Update cards on theme demo page

    @acdvorak
    acdvorak committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    bb574cc View commit details
    Browse the repository at this point in the history

  3. WIP: Fix example card background colors

    @acdvorak
    acdvorak committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    0bcb922 View commit details
    Browse the repository at this point in the history

  4. WIP: Add mixins; refactor

    @acdvorak
    acdvorak committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    aeaa446 View commit details
    Browse the repository at this point in the history

  5. WIP: Update README

    @acdvorak
    acdvorak committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    482dbe8 View commit details
    Browse the repository at this point in the history

  6. WIP: Set elevation color automatically

    @acdvorak
    acdvorak committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    06c0920 View commit details
    Browse the repository at this point in the history

  7. WIP: Removed unused CSS class

    @acdvorak
    acdvorak committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    1750a9f View commit details
    Browse the repository at this point in the history

  8. Revert "feat(base): shouldBubble now defaults to true" 

    This reverts commit 4c08741.
    @acdvorak
    acdvorak committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    c9b6278 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2018

  1. Merge remote-tracking branch 'origin/master' into chore/card/remove-l… 

    …ayouts
    @acdvorak
    acdvorak committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    86f2083 View commit details
    Browse the repository at this point in the history

  2. WIP: __media inherits border-radius from card; add radius mixin

    @acdvorak
    acdvorak committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    6fb8e12 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2018

  1. WIP: Remove mdc-card-corner-radius mixin

    @acdvorak
    acdvorak committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    0cb61b0 View commit details
    Browse the repository at this point in the history

  2. feat(card): Add mdc-card__primary-action with states 

    # INCLUDES #2025

## DO NOT MERGE until #2025 is merged first
    @acdvorak
    acdvorak committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    3997ad8 View commit details
    Browse the repository at this point in the history

  3. Revert "WIP: Remove mdc-card-corner-radius mixin" 

    This reverts commit 0cb61b0.
    @acdvorak
    acdvorak committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    4bbfd02 View commit details
    Browse the repository at this point in the history

  4. WIP: Rename __action-bar to __actions for backward compatibility

    @acdvorak
    acdvorak committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    dc4c5c3 View commit details
    Browse the repository at this point in the history

  5. WIP: Reorder mixins

    @acdvorak
    acdvorak committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    6f4acb8 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into chore/card/remove-l… 

    …ayouts
    @acdvorak
    acdvorak committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    6836c5e View commit details
    Browse the repository at this point in the history

  7. WIP: Don't override elevation color

    @acdvorak
    acdvorak committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    1f32dcd View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. Merge remote-tracking branch 'origin/master' into chore/card/remove-l… 

    …ayouts
    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    974edd6 View commit details
    Browse the repository at this point in the history

  2. WIP: Minor cleanup

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    8ce2bac View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into chore/card/remove-layouts

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    5a72bf1 View commit details
    Browse the repository at this point in the history

  4. WIP: Fix ripple overflow bug in IE 11 and Edge on demo page

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    6c5970f View commit details
    Browse the repository at this point in the history

  5. WIP: Don't wrap icons in mdc-button

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    dafbd04 View commit details
    Browse the repository at this point in the history

  6. WIP: Use # and preventDefault instead of "javascript:" links

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    8f0db4d View commit details
    Browse the repository at this point in the history

  7. WIP: Don't use event delegation for a single element

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    9fdced1 View commit details
    Browse the repository at this point in the history

  8. WIP: Remove TODO

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    45e98de View commit details
    Browse the repository at this point in the history

  9. WIP: Replace javascript: with # in readme example

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    414c981 View commit details
    Browse the repository at this point in the history

  10. WIP: Clarify that mdc-card is mandatory

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    87980a4 View commit details
    Browse the repository at this point in the history

  11. WIP: Rename mixin params

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    c0f4e51 View commit details
    Browse the repository at this point in the history

  12. WIP: Rewording

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    b7627db View commit details
    Browse the repository at this point in the history

  13. WIP: Refactoring

    @acdvorak
    acdvorak committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    49469c0 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. WIP: Fix button margins

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    24b794b View commit details
    Browse the repository at this point in the history

  2. WIP: Add __action--button class to avoid violating BEM

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    fa9073b View commit details
    Browse the repository at this point in the history

  3. WIP: Fix action button margins

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    420a1ec View commit details
    Browse the repository at this point in the history

  4. WIP: Remove unnecessary <span> element and use correct aria attr

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    ff57974 View commit details
    Browse the repository at this point in the history

  5. WIP: Semantic HTML: Use <div> instead of <section> for card areas

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    f4731c1 View commit details
    Browse the repository at this point in the history

  6. WIP: Always use mdc-card__action--button class on buttons

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    70e7c49 View commit details
    Browse the repository at this point in the history

  7. WIP: Update wording in README

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    3364d96 View commit details
    Browse the repository at this point in the history

  8. WIP: Simplify example in README

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    75f81dc View commit details
    Browse the repository at this point in the history

  9. WIP: Clean up README

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    137b74d View commit details
    Browse the repository at this point in the history

  10. WIP: Set box-sizing: border-box and display: flex on all elements

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    7c0f775 View commit details
    Browse the repository at this point in the history

  11. WIP: Set color explicitly on __action--icon rather than inheritin… 

    …g from parent
    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    51de056 View commit details
    Browse the repository at this point in the history

  12. WIP: Use <div> instead of <section>

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    689290d View commit details
    Browse the repository at this point in the history

  13. WIP: Simplify icon-only action row example

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    1503a2f View commit details
    Browse the repository at this point in the history

  14. WIP: Refactor align-items: center into mdc-card-row-layout_ mixin

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    90840cf View commit details
    Browse the repository at this point in the history

  15. Merge remote-tracking branch 'origin/master' into chore/card/remove-l… 

    …ayouts
    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    0a81243 View commit details
    Browse the repository at this point in the history

  16. WIP: Reorder ready.js import in <head>

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    3c5f572 View commit details
    Browse the repository at this point in the history

  17. WIP: Remove preventDefault for dummy links 

    Will create a separate PR
    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    fc36930 View commit details
    Browse the repository at this point in the history

  18. WIP: Import common.js

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    f177ce0 View commit details
    Browse the repository at this point in the history

  19. WIP: Update theme demo page markup

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    25a70ca View commit details
    Browse the repository at this point in the history

  20. WIP: Simplify theme demo page example

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    3a74182 View commit details
    Browse the repository at this point in the history

  21. Merge remote-tracking branch 'origin/master' into chore/card/remove-l… 

    …ayouts
    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    d26281d View commit details
    Browse the repository at this point in the history

  22. WIP: Add user-select: none to mdc-card__action

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    8e24e56 View commit details
    Browse the repository at this point in the history

  23. WIP: Use padding instead of margin on __action--icon 

    This ensures that the tap area and ripple is the same size on both icon-toggle and non-icon-toggle actions.
    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    cf07755 View commit details
    Browse the repository at this point in the history

  24. WIP: Fix import and remove unneeded class

    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    4ed5f6a View commit details
    Browse the repository at this point in the history

  25. WIP: Fix action bar height by applying negative margin to all __actio… 

    …n--icon elems
    @acdvorak
    acdvorak committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    d36e518 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2018

  1. Merge branch 'chore/card/remove-layouts' into feat/card/states 

    # Conflicts:
#	demos/card.html
#	demos/card.scss
#	packages/mdc-card/README.md
#	packages/mdc-card/mdc-card.scss
    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    2576113 View commit details
    Browse the repository at this point in the history

  2. WIP: Add data-hot attr to stylesheet element

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    4f0958c View commit details
    Browse the repository at this point in the history

  3. WIP: Remove extra element from merge conflict

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    5bce402 View commit details
    Browse the repository at this point in the history

  4. WIP: Inherit color and disable underline for __primary-action 

    The `__primary-action` element will often be a hyperlink (e.g., `<a href="foo.html" class="mdc-card__primary-action">`), so we might as well save clients the trouble of disabling the default browser styles for links.
    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    f0eb759 View commit details
    Browse the repository at this point in the history

  5. WIP: Remove unneeded style property

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    0129f53 View commit details
    Browse the repository at this point in the history

  6. WIP: Fix README indentation of code examples

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    2cba692 View commit details
    Browse the repository at this point in the history

  7. WIP: Fix indentation

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    fdd4eb1 View commit details
    Browse the repository at this point in the history

  8. WIP: Show custom corner radius; rename demo classes

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    8f000b6 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'chore/card/remove-layouts' into feat/card/states 

    # Conflicts:
#	demos/card.html
    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    379c541 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/master' into feat/card/states 

    # Conflicts:
#	demos/card.html
#	demos/card.scss
#	packages/mdc-card/README.md
#	packages/mdc-card/_mixins.scss
#	packages/mdc-card/mdc-card.scss
    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    baacdd2 View commit details
    Browse the repository at this point in the history

  11. WIP: Fix __media element height

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    2069984 View commit details
    Browse the repository at this point in the history

  12. WIP: Remove unnecessary :focus selector

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    c498e8b View commit details
    Browse the repository at this point in the history

  13. WIP: Remove unnecessary width: 100%

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    0a96446 View commit details
    Browse the repository at this point in the history

  14. WIP: Fix merge conflicts

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    70d23bf View commit details
    Browse the repository at this point in the history

  15. WIP: Add border-box to __primary-action

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    70e0e90 View commit details
    Browse the repository at this point in the history

  16. WIP: Fix merge conflict in README

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    9050309 View commit details
    Browse the repository at this point in the history

  17. WIP: Update wording in README

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    276b221 View commit details
    Browse the repository at this point in the history

  18. WIP: Remove data-hot attr (create new PR instead)

    @acdvorak
    acdvorak committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    1a0ac4d View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2018

  1. Merge branch 'master' into feat/card/states 

    # Conflicts:
#	packages/mdc-card/README.md
    @acdvorak
    acdvorak committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    bdba1d8 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2018

  1. Merge remote-tracking branch 'origin' into feat/card/states

    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    671f128 View commit details
    Browse the repository at this point in the history

  2. WIP: Fix broken build by updating mixin name

    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    17fb14f View commit details
    Browse the repository at this point in the history

  3. WIP: Clarify usage of __primary-action in README

    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    d1563ce View commit details
    Browse the repository at this point in the history

  4. WIP: Remove unnecessary 0

    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    5659d54 View commit details
    Browse the repository at this point in the history

  5. WIP: Move flexbox styles from __media to __primary-action

    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    6a30d54 View commit details
    Browse the repository at this point in the history

  6. WIP: Move common code into mixin

    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    e3648a8 View commit details
    Browse the repository at this point in the history

  7. WIP: Compat for IE, Edge, and Safari

    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    aff87a1 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin' into feat/card/states

    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    d1b92bc View commit details
    Browse the repository at this point in the history

  9. WIP: Move box-sizing into layout mixins

    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    9287220 View commit details
    Browse the repository at this point in the history

  10. WIP: Remove min-width from __action 

    `.mdc-button` sets a `min-width`, but `mdc-icon-toggle` does not. The `min-width: 0` was originally to override the `mdc-button` style, but that creates bad UX because it makes the tap target too small if the text is short (e.g., an "OK" button).
    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    9a74141 View commit details
    Browse the repository at this point in the history

  11. WIP: Move justify-content out of mixin into __action

    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    5080a86 View commit details
    Browse the repository at this point in the history

  12. WIP: Add cursor:pointer to __primary-action

    @acdvorak
    acdvorak committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    941c6f0 View commit details
    Browse the repository at this point in the history