fix(snackbar): Drop mdc-button from snackbar's dependency #1292
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1292 +/- ##
======================================
Coverage 99.9% 99.9%
======================================
Files 69 69
Lines 3314 3314
Branches 409 409
======================================
Hits 3311 3311
Misses 3 3Continue to review full report at Codecov.
|
yeelan0319
force-pushed
the
fix/snackbar-action-button-regression
branch
from
0724b1b
to
95e9388
Compare
yeelan0319
changed the title
| @include mdc-theme-prop(color, secondary); | ||
|
|
||
| @include mdc-theme-dark(".mdc-snackbar") { | ||
| @include mdc-theme-prop(color, primary); | ||
| } | ||
|
|
||
| @include mdc-rtl-reflexive-box(margin, right, -16px, ".mdc-snackbar"); |
There was a problem hiding this comment.
Why was this line removed? This effectively shifts the action button to the left 16px.
There was a problem hiding this comment.
This line used to be the mechanism to reverse padding introduce by button, since now there is no longer padding: 0 16px, we also could safely remove the margin-direction: -16px here.
Could you take a look at the deployed dev server and see if this style looks correct to you?
|
|
|
Good catch, seems like Chrome add some padding by default to button. My overlook indeed! Thanks @amsheehan |
BREAKING CHANGE: Removed the dependency of mdc-button from DOM structure of snackbar.
yeelan0319
force-pushed
the
fix/snackbar-action-button-regression
branch
from
95e9388
to
6548a9b
Compare
yeelan0319
dismissed
kfranqueiro’s stale review
Sorry Ken to dismiss your review. Feel relax to rest at home :)
There was a problem hiding this comment.
I think @amsheehan's observation may have coincided with my own, and it looks like it's resolved now. Thanks both of you!
BREAKING CHANGE: Removed the dependency of mdc-button from DOM structure of snackbar.
Dev server: 1292-dot-mdc-web-dev.xxxx.com
Background
The rationale behind dropping button from snackbar is
action-buttonis not technically aMDC buttonfrom the design perspective.So to prevent future regression, we remove the dependency of button from snackbar by directly styling
action button. The changes increase CSS file by 10 lines, but the actual size remained same 10KB.