Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page content can be scrolled even if drawer is open. #777

Closed
touficbatache opened this issue Jun 2, 2017 · 1 comment
Closed

Page content can be scrolled even if drawer is open. #777

touficbatache opened this issue Jun 2, 2017 · 1 comment
Labels
help wanted

Comments

@touficbatache
Copy link
Contributor

touficbatache commented Jun 2, 2017 •
edited
Loading

What MDC-Web Version are you using?

0.12.1

What browser(s) is this bug affecting?

Chrome 58.0.3029.110

What OS are you using?

Windows 7 Professional

What are the steps to reproduce the bug?

  1. Go to the catalog page.
  2. Have a lot of page content that can be scrolled.
  3. Open the drawer then scroll up or down.
  4. Observe what happens.

What is the expected behavior?

You shouldn't be able to scroll the page's content.

What is the actual behavior?

The page content can be scrolled up and down as the drawer is open.
@touficbatache touficbatache changed the title Closing drawer by swiping causes a grey screen overlay Page content can be scrolled even if drawer is open. Jun 2, 2017
@touficbatache touficbatache reopened this Jun 2, 2017
@amsheehan
Copy link
Contributor

I believe we can take the same approach as mdc-dialog to solve this.

  • Add two methods addBodyClass and removeBodyClass to the adapter. These methods will add/remove some classname to the body.
  • Style the class such that it sets height: 100vh and overflow: hidden
  • Write tests for the new methods
  • Document the new methods in the README
  • Mark as a Breaking Change: in the last commit message

vinhlh added a commit to vinhlh/material-components-web that referenced this issue Jun 9, 2017
@vinhlh
fix(drawer): Page content can be scrolled even if drawer is open
0fbf1e7 
BREAKING CHANGE: Adapter API for drawers contains two new methods: `addBodyClass` and
`removeBodyClass`.

Closes material-components#777
vinhlh added a commit to vinhlh/material-components-web that referenced this issue Jun 9, 2017
@vinhlh
fix(drawer): Page content can be scrolled even if drawer is open
e82b2ab 
BREAKING CHANGE: Adapter API for temporary drawers contains two new methods: `addBodyClass` and
`removeBodyClass`.

Closes material-components#777
@vinhlh vinhlh mentioned this issue Jun 9, 2017
Merged
vinhlh added a commit to vinhlh/material-components-web that referenced this issue Jun 9, 2017
@vinhlh
fix(drawer): Page content can be scrolled even if drawer is open
1256261 
BREAKING CHANGE: Adapter API for temporary drawers contains two new methods: `addBodyClass` and
`removeBodyClass`.

Closes material-components#777
vinhlh added a commit to vinhlh/material-components-web that referenced this issue Jun 11, 2017
@vinhlh
fix(drawer): Page content can be scrolled even if drawer is open
f5b41e9 
BREAKING CHANGE: Adapter API for temporary drawers contains two new methods: `addBodyClass` and
`removeBodyClass`.

Closes material-components#777
traviskaufman pushed a commit that referenced this issue Jun 12, 2017
@vinhlh @traviskaufman
fix(drawer): Prevent scrolling on body when temporary drawer open (#807)
8686d85 
Closes #777

BREAKING CHANGE: Adapter API for temporary drawers contains two new methods: `addBodyClass` and `removeBodyClass`.
@touficbatache touficbatache mentioned this issue Jun 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amsheehan @touficbatache