Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): RTL does not have 8dp padding between side-by-side buttons #750

Closed
robzenn92 opened this issue May 30, 2017 · 1 comment
Closed

Comments

@robzenn92
Copy link
Contributor

This issue is related to #661 which introduces 8dp padding between side-by-side buttons but does not take into account the RTL context.

What MDC-Web Version are you using?

0.12.0

What browser(s) is this bug affecting?

All of them

What OS are you using?

macOS 10.12.4

What are the steps to reproduce the bug?

  1. Open http://localhost:8080/dialog.html or visit the demo page
  2. Check on Toggle RTL

What is the expected behavior?

There should be 8dp padding between side-by-side buttons

What is the actual behavior?

There is no 8dp padding between side-by-side buttons.

rtl dialog

@robzenn92
Copy link
Contributor Author

robzenn92 commented May 30, 2017

This should be solved using mdc-rtl-reflexive-box within line L137 as follows:

&__button {
  @include mdc-rtl-reflexive-box(margin, right, 8px);

  &:last-child {
    @include mdc-rtl-reflexive-box(margin, right, 0);
  }
}

rtl works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant