Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDCDrawer] Missing Theming Property #6466

Closed
aress31 opened this issue Sep 11, 2020 · 1 comment · Fixed by #6470
Closed

[MDCDrawer] Missing Theming Property #6466

aress31 opened this issue Sep 11, 2020 · 1 comment · Fixed by #6470
Assignees
@e111077
Labels
feature-request

Comments

@aress31
Copy link

aress31 commented Sep 11, 2020

Bug report

The mdc-drawer does not export the --mdc-theme-surface property to allow styling the background for different theme, right now my application got a dark/light mode, but the drawer remains always white.

Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Actual behavior

  • Dark mode:
    image

-Light mode:
image

Expected behavior

I would expect to explicitly set the background colour for the mdc-drawer so that I can adapt it to my different themes.

Screenshots

Your Environment:

Software Version(s)
MDC Web
Browser: Google Chrome: Version 85.0.4183.102 (Official Build) (64-bit)
Operating System: Windows 10 Pro - latest build

Additional context

Possible solution
@aress31 aress31 added the bug label Sep 11, 2020
@asyncLiz
Copy link
Contributor

asyncLiz commented Sep 11, 2020 •
edited
Loading

prop-value() needs to be removed from the following areas to expose the --mdc-theme-surface custom property:

@asyncLiz asyncLiz assigned asyncLiz and e111077 and unassigned asyncLiz Sep 11, 2020
copybara-service bot pushed a commit that referenced this issue Sep 11, 2020
@copybara-github
feat(drawer): expose --mdc-theme-surface custom prop
51e453a 
fixes #6466

PiperOrigin-RevId: 331219139
@copybara-service copybara-service bot mentioned this issue Sep 11, 2020
Merged
@adrianschmidt adrianschmidt mentioned this issue Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e111077 e111077

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(drawer): expose --mdc-theme-surface custom prop material-components/material-components-web
3 participants
@e111077 @aress31 @asyncLiz