Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(switch): set track border to be transparent #5323

Merged
merged 3 commits into from
Dec 12, 2019
Merged

Conversation

allan-chen
Copy link
Collaborator

@allan-chen allan-chen commented Dec 11, 2019

This will allow track colors to be customized with alpha without having to worry about border color stacking on top of content color.

Theoretically this should result in no visual changes, since now we just have a transparent border on top of the old content background color. However, browsers still seem to want to shuffle pixels around at the rounded corners.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #5323 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5323      +/-   ##
==========================================
+ Coverage   98.57%   98.57%   +<.01%     
==========================================
  Files         162      162              
  Lines        6311     6312       +1     
  Branches      866      866              
==========================================
+ Hits         6221     6222       +1     
  Misses         89       89              
  Partials        1        1
Impacted Files Coverage Δ
testing/helpers/foundation.ts 87.5% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878a08b...a4058ca. Read the comment docs.

@allan-chen allan-chen changed the title Project import generated by Copybara. Set all track borders to be transparent Dec 11, 2019
@allan-chen allan-chen changed the title Set all track borders to be transparent fix(switch): set track border to be transparent Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants