-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linear-progress): Add aria attributes to linear progress bar to support screen readers #5248
fix(linear-progress): Add aria attributes to linear progress bar to support screen readers #5248
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5248 +/- ##
==========================================
+ Coverage 98.63% 98.91% +0.28%
==========================================
Files 122 122
Lines 6002 6011 +9
Branches 774 774
==========================================
+ Hits 5920 5946 +26
+ Misses 81 64 -17
Partials 1 1
Continue to review full report at Codecov.
|
2b8e67b
to
15b5099
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Please add a BREAKING CHANGE message to the description per https://github.com/angular/angular/blob/master/CONTRIBUTING.md#footer, since we're adding two adapter methods.
Also create the equivalent CL in google3. I will merge this in when that CL is ready to go.
2acd374
to
d1ce40e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please make sure to include BREAKING CHANGE: line in your commit message, when you squash & merge so that it'll appear nicely in our CHANGELOG :)
Adds aria attributes to MDC Linear progress to support screen readers. BREAKING CHANGE: Adds new adapter methods to MDCLinearProgressAdapter.
d1ce40e
to
675c9c7
Compare
Squashed and added that to the commit message :-) |
fix(linear-progress) support aria attributes
Adds aria attributes to MDC Linear progress to support screen readers.
BREAKING CHANGE: Adds new adapter methods to MDCLinearProgressAdapter.