Update ripple and tab-scroller to use mdc-dom/ponyfill.matches #4340

kfranqueiro · 2019-02-01T17:04:06Z

We added an mdc-dom package with a common matches function, but we still have 2 packages using their own version: Ripple and Tab Scroller.

Additionally, these packages use a version which is run eagerly ahead-of-time, which poses problems in SSR scenarios. (See material-components/material-components-web-react#654)

Edit: Only Ripple actually runs the function eagerly, although both work in the same manner.

We should update these components to use mdc-dom and remove the duplicate functions.

The text was updated successfully, but these errors were encountered:

Fixes #4340 `mdc-dom` implements a `matches()` method that wasn't used everywhere. These custom implementations prevented some SSR usage of the material-components library. This commit removes all the custom implementations. I removed some tests that were testing a now removed method, and I handled to make the other pass. PS: This is my first contribution here, I hope I did everything right! BREAKING CHANGE: `getMatchesProperty()` has been removed from `@material/ripple/util`. Use `matches()` from `@material/dom/ponyfill` instead.

Fixes #4340 `mdc-dom` implements a `matches()` method that wasn't used everywhere. These custom implementations prevented some SSR usage of the material-components library. This commit removes all the custom implementations. I removed some tests that were testing a now removed method, and I handled to make the other pass. PS: This is my first contribution here, I hope I did everything right! BREAKING CHANGE: `getMatchesProperty()` has been removed from `@material/ripple/util` and `@material/tab-scroller/util`. Use `matches()` from `@material/dom/ponyfill` instead.

abhiomkar added this to the 0.45.0 milestone Feb 4, 2019

julien1619 mentioned this issue Feb 7, 2019

fix(ripple): Use mdc-dom.matches everywhere instead of a custom one (#4340) #4372

Merged

kfranqueiro mentioned this issue Feb 11, 2019

chore: Remove Object.assign from TS files #4389

Merged

acdvorak closed this as completed in #4372 Feb 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ripple and tab-scroller to use mdc-dom/ponyfill.matches #4340

Update ripple and tab-scroller to use mdc-dom/ponyfill.matches #4340

kfranqueiro commented Feb 1, 2019 •

edited

Loading

Update ripple and tab-scroller to use mdc-dom/ponyfill.matches #4340

Update ripple and tab-scroller to use mdc-dom/ponyfill.matches #4340

Comments

kfranqueiro commented Feb 1, 2019 • edited Loading

kfranqueiro commented Feb 1, 2019 •

edited

Loading