Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Radio getNativeControl from adapter #3763

Closed
moog16 opened this issue Oct 15, 2018 · 0 comments · Fixed by #3785
Closed

Remove Radio getNativeControl from adapter #3763

moog16 opened this issue Oct 15, 2018 · 0 comments · Fixed by #3785
Assignees
@moog16

Comments

@moog16
Copy link
Contributor

moog16 commented Oct 15, 2018

Similar to this issue: #3396

There are a few methods in the radio adapter that should instead be handled by the component:

isChecked
setChecked
isDisabled
getValue
setValue

setDisabled is a special case since there is some business logic, but we should move this.getNativeControl_().disabled = disabled; into the component and out from foundation.

Once the above are moved, getNativeControl_ can be removed from the foundation, which partially fixes #2684.
@moog16 moog16 self-assigned this Oct 15, 2018
@moog16 moog16 changed the title Move Radio getNativeControl from adapter into component Remove Radio getNativeControl from adapter into component Oct 15, 2018
@moog16 moog16 changed the title Remove Radio getNativeControl from adapter into component Remove Radio getNativeControl from adapter Oct 15, 2018
@moog16 moog16 mentioned this issue Oct 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moog16 moog16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(radio): remove getNativeControl from adapter material-components/material-components-web
1 participant
@moog16