Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox/Radio: Investigate removing no-input-element fallback logic #2684

Open
kfranqueiro opened this issue Apr 30, 2018 · 0 comments
Open

Comments

@kfranqueiro
Copy link
Contributor

We currently have this code in radio, and similar code in checkbox:

https://github.com/material-components/material-components-web/blob/v0.35.0/packages/mdc-radio/foundation.js#L84-L94

This includes code that falls back to a dummy object if a native input isn't found.

I'm fairly certain this was done to appease closure compiler, but I don't think we should even need this fallback in order to do that. (FWIW, this fallback has existed in code since 1.5 years ago.)

The reason it's perhaps a bit problematic is because it leaks complexity into our API docs (and probably also tests, if I had to guess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants