Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add !default to all Sass variables #3708

Closed
acdvorak opened this issue Oct 5, 2018 · 1 comment
Closed

Add !default to all Sass variables #3708

acdvorak opened this issue Oct 5, 2018 · 1 comment
Milestone
v0.43.0

Comments

@acdvorak
Copy link
Contributor

acdvorak commented Oct 5, 2018

See #3635 for motivation

Document the fact that backward compatibility is not guaranteed: "You should not do this, but if you need to, you're on your own."
@acdvorak acdvorak added this to the R21 milestone Oct 5, 2018
@jantimon
Copy link

Using !default is a best practice for scss libraries.
This would be a great addition to this project 👍

@kfranqueiro kfranqueiro modified the milestones: R21 (v0.42.0), v0.43.0 Nov 9, 2018
@mathiasschopmans mathiasschopmans mentioned this issue Dec 14, 2018
Merged
acdvorak pushed a commit that referenced this issue Dec 14, 2018
@mathiasschopmans @acdvorak
feat(checkbox): Declare all Sass variables as !default
de6c833 
All Sass variables are now declared as `!default` so they can be overridden by clients.

Refs #3708
levibotelho added a commit to levibotelho/material-components-web that referenced this issue Dec 18, 2018
@levibotelho
feat: Set all variables to !default (material-components#3708)
1f75cbd
levibotelho added a commit to levibotelho/material-components-web that referenced this issue Dec 18, 2018
@levibotelho
feat: Set all variables to !default (material-components#3708)
8c6b8d7
@levibotelho levibotelho mentioned this issue Dec 18, 2018
Merged
abhiomkar pushed a commit that referenced this issue Jan 4, 2019
@levibotelho @abhiomkar
chore: Declare all sass variables as !default (#3708) (#4195)
cb344c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.43.0
Development

No branches or pull requests
3 participants
@kfranqueiro @acdvorak @jantimon