Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): Remove list CSS, and use mdc-list styles directly #2065

Merged
merged 2 commits into from
Jan 24, 2018

Conversation

lynnmercier
Copy link
Contributor

No description provided.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Jan 24, 2018

Codecov Report

Merging #2065 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2065      +/-   ##
==========================================
- Coverage   99.43%   99.43%   -0.01%     
==========================================
  Files          84       84              
  Lines        3720     3718       -2     
  Branches      485      485              
==========================================
- Hits         3699     3697       -2     
  Misses         21       21
Impacted Files Coverage Δ
packages/mdc-slider/foundation.js 100% <0%> (ø) ⬆️
packages/mdc-menu/index.js
packages/mdc-menu/constants.js
packages/mdc-menu/foundation.js
packages/mdc-menu/simple/foundation.js 99.26% <0%> (ø)
packages/mdc-menu/simple/constants.js 100% <0%> (ø)
packages/mdc-menu/simple/index.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fffb18...854b87b. Read the comment docs.

@lynnmercier lynnmercier merged commit e588392 into master Jan 24, 2018
@lynnmercier lynnmercier deleted the fix/select/use-list-directly branch January 24, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants