Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider: Discrete slider not initializing current value #1173

Closed
archnode opened this issue Aug 23, 2017 · 4 comments · Fixed by #1245
Closed

Slider: Discrete slider not initializing current value #1173

archnode opened this issue Aug 23, 2017 · 4 comments · Fixed by #1245
Labels

Comments

@archnode
Copy link
Contributor

What MDC-Web Version are you using?

v. 0.0.18

What are the steps to reproduce the bug?

  1. Set aria-valuenow to a certain value
  2. Initialize the Slider with autoinit or js
  3. Check the initialized sliders value

What is the expected behavior?

The initial state of the slider is set to the value specified with aria-valuenow.

What is the actual behavior?

The initial value of the slider is shown (and initialized as) zero.

Other information

The behavior can be observed in the demos as well.
Thanks for your work on these great components!

@aaronhudon
Copy link
Contributor

Quick codepen using latest sources show's it's broken as of 2017-08-24

https://codepen.io/aaronhudon/pen/xLJPMY

@kfranqueiro
Copy link
Contributor

Thanks for bringing this to our attention! Definitely seems like a bug.

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Aug 24, 2017

Based on fiddling with the unpkg URLs in @aaronhudon's CodePen, it looks as if this worked in 0.14.0 but doesn't work in 0.15.0. That should help us narrow down to investigate.

Edit: Actually, 0.15.0 is when discrete was introduced, so this problem may have existed with discrete sliders from the beginning.

@archnode
Copy link
Contributor Author

Tried my best to provide a pull request and a (micro) fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants