Skip to content

Commit

Permalink
feat(shape): Golden screenshots for dialog
Browse files Browse the repository at this point in the history
  • Loading branch information
abhiomkar committed Sep 21, 2018
1 parent dbf5a7a commit b7ca944
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 30 deletions.
18 changes: 9 additions & 9 deletions test/screenshot/golden.json
Original file line number Diff line number Diff line change
Expand Up @@ -467,15 +467,6 @@
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/21/16_50_45_748/spec/mdc-dialog/mixins/content-ink-color.html.windows_ie_11.png"
}
},
"spec/mdc-dialog/mixins/corner-radius.html": {
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/21/16_50_45_748/spec/mdc-dialog/mixins/corner-radius.html?utm_source=golden_json",
"screenshots": {
"desktop_windows_chrome@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/21/16_50_45_748/spec/mdc-dialog/mixins/corner-radius.html.windows_chrome_69.png",
"desktop_windows_edge@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/21/16_50_45_748/spec/mdc-dialog/mixins/corner-radius.html.windows_edge_17.png",
"desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/21/16_50_45_748/spec/mdc-dialog/mixins/corner-radius.html.windows_firefox_62.png",
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/21/16_50_45_748/spec/mdc-dialog/mixins/corner-radius.html.windows_ie_11.png"
}
},
"spec/mdc-dialog/mixins/max-height.html": {
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/21/16_50_45_748/spec/mdc-dialog/mixins/max-height.html?utm_source=golden_json",
"screenshots": {
Expand Down Expand Up @@ -521,6 +512,15 @@
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/21/16_50_45_748/spec/mdc-dialog/mixins/scroll-divider-color.html.windows_ie_11.png"
}
},
"spec/mdc-dialog/mixins/shape-radius.html": {
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2018/09/21/22_25_39_766/spec/mdc-dialog/mixins/shape-radius.html?utm_source=golden_json",
"screenshots": {
"desktop_windows_chrome@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2018/09/21/22_25_39_766/spec/mdc-dialog/mixins/shape-radius.html.windows_chrome_69.png",
"desktop_windows_edge@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2018/09/21/22_25_39_766/spec/mdc-dialog/mixins/shape-radius.html.windows_edge_17.png",
"desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2018/09/21/22_25_39_766/spec/mdc-dialog/mixins/shape-radius.html.windows_firefox_62.png",
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2018/09/21/22_25_39_766/spec/mdc-dialog/mixins/shape-radius.html.windows_ie_11.png"
}
},
"spec/mdc-dialog/mixins/title-ink-color.html": {
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/21/16_50_45_748/spec/mdc-dialog/mixins/title-ink-color.html?utm_source=golden_json",
"screenshots": {
Expand Down
4 changes: 2 additions & 2 deletions test/screenshot/spec/mdc-chips/fixture.scss
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ $custom-chip-ink-color: $material-color-blue-500;
@include mdc-chip-set-spacing(20px);
}

.custom-chip--corner-radius {
@include mdc-chip-corner-radius(10px);
.custom-chip--shape-radius {
@include mdc-chip-shape-radius(10px);
}

.custom-chip--fill-color-accessible {
Expand Down
32 changes: 16 additions & 16 deletions test/screenshot/spec/mdc-chips/mixins/corner-radius.html
Original file line number Diff line number Diff line change
Expand Up @@ -44,36 +44,36 @@
<div class="test-layout">
<div class="test-cell test-cell--chip">
<div class="mdc-chip-set">
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<div class="mdc-chip__text">Chip One</div>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<div class="mdc-chip__text">Chip Two</div>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<div class="mdc-chip__text">Chip Three</div>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<div class="mdc-chip__text">Chip Four</div>
</div>
</div>
</div>

<div class="test-cell test-cell--chip">
<div class="mdc-chip-set">
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<i class="material-icons mdc-chip__icon mdc-chip__icon--leading">event</i>
<div class="mdc-chip__text">Chip One</div>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<i class="material-icons mdc-chip__icon mdc-chip__icon--leading">bookmark</i>
<div class="mdc-chip__text">Chip Two</div>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<i class="material-icons mdc-chip__icon mdc-chip__icon--leading">alarm</i>
<div class="mdc-chip__text">Chip Three</div>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<i class="material-icons mdc-chip__icon mdc-chip__icon--leading">directions</i>
<div class="mdc-chip__text">Chip Four</div>
</div>
Expand All @@ -82,31 +82,31 @@

<div class="test-cell test-cell--chip">
<div class="mdc-chip-set mdc-chip-set--filter">
<div class="mdc-chip custom-chip custom-chip--corner-radius mdc-chip--selected" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius mdc-chip--selected" tabindex="0">
<div class="mdc-chip__checkmark" >
<svg class="mdc-chip__checkmark-svg" viewBox="-2 -3 30 30">
<path class="mdc-chip__checkmark-path" fill="none" stroke="black" d="M1.73,12.91 8.1,19.28 22.79,4.59"/>
</svg>
</div>
<div class="mdc-chip__text">Chip One</div>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius mdc-chip--selected" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius mdc-chip--selected" tabindex="0">
<div class="mdc-chip__checkmark" >
<svg class="mdc-chip__checkmark-svg" viewBox="-2 -3 30 30">
<path class="mdc-chip__checkmark-path" fill="none" stroke="black" d="M1.73,12.91 8.1,19.28 22.79,4.59"/>
</svg>
</div>
<div class="mdc-chip__text">Chip Two</div>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius mdc-chip--selected" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius mdc-chip--selected" tabindex="0">
<div class="mdc-chip__checkmark" >
<svg class="mdc-chip__checkmark-svg" viewBox="-2 -3 30 30">
<path class="mdc-chip__checkmark-path" fill="none" stroke="black" d="M1.73,12.91 8.1,19.28 22.79,4.59"/>
</svg>
</div>
<div class="mdc-chip__text">Chip Three</div>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius mdc-chip--selected" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius mdc-chip--selected" tabindex="0">
<div class="mdc-chip__checkmark" >
<svg class="mdc-chip__checkmark-svg" viewBox="-2 -3 30 30">
<path class="mdc-chip__checkmark-path" fill="none" stroke="black" d="M1.73,12.91 8.1,19.28 22.79,4.59"/>
Expand All @@ -119,22 +119,22 @@

<div class="test-cell test-cell--chip">
<div class="mdc-chip-set mdc-chip-set--input">
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<i class="material-icons mdc-chip__icon mdc-chip__icon--leading">event</i>
<div class="mdc-chip__text">Chip One</div>
<i class="material-icons mdc-chip__icon mdc-chip__icon--trailing" tabindex="0" role="button">cancel</i>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<i class="material-icons mdc-chip__icon mdc-chip__icon--leading">bookmark</i>
<div class="mdc-chip__text">Chip Two</div>
<i class="material-icons mdc-chip__icon mdc-chip__icon--trailing" tabindex="0" role="button">cancel</i>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<i class="material-icons mdc-chip__icon mdc-chip__icon--leading">alarm</i>
<div class="mdc-chip__text">Chip Three</div>
<i class="material-icons mdc-chip__icon mdc-chip__icon--trailing" tabindex="0" role="button">cancel</i>
</div>
<div class="mdc-chip custom-chip custom-chip--corner-radius" tabindex="0">
<div class="mdc-chip custom-chip custom-chip--shape-radius" tabindex="0">
<i class="material-icons mdc-chip__icon mdc-chip__icon--leading">directions</i>
<div class="mdc-chip__text">Chip Four</div>
<i class="material-icons mdc-chip__icon mdc-chip__icon--trailing" tabindex="0" role="button">cancel</i>
Expand Down
5 changes: 2 additions & 3 deletions test/screenshot/spec/mdc-dialog/fixture.scss
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ $custom-dialog-color: $material-color-red-300;
@include mdc-dialog-scroll-divider-color($custom-dialog-color, .5);
}

.test-dialog--corner-radius {
@include mdc-dialog-corner-radius(10px);
.test-dialog--shape-radius {
@include mdc-dialog-shape-radius(10px);
}

.test-dialog--min-width {
Expand All @@ -83,4 +83,3 @@ $custom-dialog-color: $material-color-red-300;
.test-dialog--max-height {
@include mdc-dialog-max-height(400px, 30px);
}

0 comments on commit b7ca944

Please sign in to comment.