Skip to content

Commit

Permalink
fix(button): Fixed parameter default value in height mixin
Browse files Browse the repository at this point in the history
  • Loading branch information
abhiomkar committed Nov 8, 2019
1 parent af1fc59 commit 1051d76
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/mdc-button/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ Mixin | Description
`mdc-button-ink-color($color)` | Sets the ink color to the given color for an enabled button, and sets the icon color to the given color unless `mdc-button-icon-color` is also used.
`mdc-button-disabled-ink-color($color)` | Sets the ink color to the given color for a disabled button, and sets the icon color to the given color unless `mdc-button-icon-color` is also used.
`mdc-button-density($density-scale)` | Sets density scale for button. Supported density scale values (`-3`, `-2`, `-1`, `0`).
`mdc-button-height($height)` | Sets custom height of button.
`mdc-button-height($height)` | Sets custom height for button.
`mdc-button-shape-radius($radius, $density-scale, $rtl-reflexive)` | Sets rounded shape to button with given radius size. `$density-scale` is only required when `$radius` value is in percentage unit, defaults to `$mdc-button-density-default-scale`. Set `$rtl-reflexive` to true to flip radius values in RTL context, defaults to false.
`mdc-button-horizontal-padding($padding)` | Sets horizontal padding to the given number.
`mdc-button-outline-color($color)` | Sets the outline color to the given color for an enabled button.
Expand Down
6 changes: 5 additions & 1 deletion packages/mdc-button/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,11 @@ $mdc-button-ripple-target: ".mdc-button__ripple";
}
}

@mixin mdc-button-height($height, $query: $query) {
///
/// Sets custom height for button.
/// @param {Number} $height - Height of button in `px`.
///
@mixin mdc-button-height($height, $query: mdc-feature-all()) {
$feat-structure: mdc-feature-create-target($query, structure);

@include mdc-feature-targets($feat-structure) {
Expand Down

0 comments on commit 1051d76

Please sign in to comment.