Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-field): label isn't float when set value with setState #934

Merged
merged 5 commits into from Jun 19, 2019
Merged

fix(text-field): label isn't float when set value with setState #934

merged 5 commits into from Jun 19, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 15, 2019

fixes #895

breaking changes
handleValueChange is removed from Input's props.

@codecov-io
Copy link

codecov-io commented Jun 15, 2019

Codecov Report

Merging #934 into rc0.14.0 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc0.14.0     #934      +/-   ##
============================================
- Coverage     94.08%   94.08%   -0.01%     
============================================
  Files            86       86              
  Lines          3636     3634       -2     
  Branches        573      572       -1     
============================================
- Hits           3421     3419       -2     
  Misses           90       90              
  Partials        125      125
Impacted Files Coverage Δ
packages/text-field/Input.tsx 100% <100%> (ø) ⬆️
packages/tab/index.tsx 95.6% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf3ea77...4ccf3ef. Read the comment docs.

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the original issue happened when this line was removed accidentally. 0f63a69#diff-ef11ab75536389f3f9e30b23c671f9baL294

We shouldn't be calling the adapter directly. I'm looking into how we can change this by introducing back the removed line.

@ghost
Copy link
Author

ghost commented Jun 17, 2019

Ah I see, then I'll close this PR..!

@ghost ghost closed this Jun 17, 2019
Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TroyTae Can you please update this and the unit tests?

@ghost ghost reopened this Jun 18, 2019
@moog16
Copy link

moog16 commented Jun 18, 2019

please remove handlevalueChange from all tests and source code:

test('#componentDidMount calls props.handleValueChange when the foundation initializes with a value', () => {

@ghost
Copy link
Author

ghost commented Jun 19, 2019

@moog16
I reflected it!
I guess we need to explain about this in CHANGELOG.md :)

@moog16
Copy link

moog16 commented Jun 19, 2019

Changelog is generated - so not worries about CHANGELOG. Changes look good!

@moog16 moog16 merged commit f829e12 into material-components:rc0.14.0 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants