-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(text-field): label isn't float when set value with setState #934
Conversation
Codecov Report
@@ Coverage Diff @@
## rc0.14.0 #934 +/- ##
============================================
- Coverage 94.08% 94.08% -0.01%
============================================
Files 86 86
Lines 3636 3634 -2
Branches 573 572 -1
============================================
- Hits 3421 3419 -2
Misses 90 90
Partials 125 125
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the original issue happened when this line was removed accidentally. 0f63a69#diff-ef11ab75536389f3f9e30b23c671f9baL294
We shouldn't be calling the adapter directly. I'm looking into how we can change this by introducing back the removed line.
Ah I see, then I'll close this PR..! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TroyTae Can you please update this and the unit tests?
please remove handlevalueChange from all tests and source code:
|
@moog16 |
Changelog is generated - so not worries about CHANGELOG. Changes look good! |
fixes #895
breaking changes
handleValueChange
is removed from Input's props.