Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tab): Allow to render Tab as an anchor node #928

Merged
merged 1 commit into from
Jun 17, 2019
Merged

feat(tab): Allow to render Tab as an anchor node #928

merged 1 commit into from
Jun 17, 2019

Conversation

barteksekula
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@barteksekula
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #928 into rc0.14.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc0.14.0     #928      +/-   ##
============================================
+ Coverage     94.08%   94.08%   +<.01%     
============================================
  Files            86       86              
  Lines          3636     3637       +1     
  Branches        573      573              
============================================
+ Hits           3421     3422       +1     
  Misses           90       90              
  Partials        125      125
Impacted Files Coverage Δ
packages/tab/index.tsx 95.6% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf3ea77...8b7f3b9. Read the comment docs.

@barteksekula
Copy link
Contributor Author

not sure why the build failed for me, the failed tests does not seem to be related with my change, but probably they are, I will try to find out why

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update base branch to be rc0.14.0. thanks!

@moog16
Copy link

moog16 commented Jun 13, 2019

@barteksekula I tried running the screenshot tests (npm start). There are a lot of TS errors resulting in the screenshot tests failing. Can you please take a look?

@barteksekula
Copy link
Contributor Author

@moog16 it's strange because I'm not getting any ts errors after running npm start.
however travis is saying that my changes caused test failures in for example select/native select.
I'm trying to set up screenshot tests locally so I can test this out myself (I know I should have done that before submitting the PR - sorry for that.. :) but I naively assumed my changes will not cause any of those).

@barteksekula barteksekula changed the base branch from master to rc0.14.0 June 15, 2019 18:08
@moog16
Copy link

moog16 commented Jun 17, 2019

@barteksekula this shouldn't be affecting the other screenshot tests. I don't think it should even affect the tab component. I'll look into this.

@moog16
Copy link

moog16 commented Jun 17, 2019

Can you please make sure you are up to date on the latest rc0.14.0 branch?

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@barteksekula
Copy link
Contributor Author

@moog16 great, I rebased and now it's all green. thanks! :)

@moog16
Copy link

moog16 commented Jun 17, 2019

Great! Thanks :)

@barteksekula
Copy link
Contributor Author

@moog16 do I have to do anything else to finalize this? closes #920

@moog16 moog16 merged commit 5108e76 into material-components:rc0.14.0 Jun 17, 2019
@moog16
Copy link

moog16 commented Jun 17, 2019

Thanks for your contribution!

@barteksekula barteksekula deleted the add-tag-prop-to-tab-component branch June 17, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants